Repository navigation
feat: route nlp2cmd vision through central SubLLM - #1
Conversation
CAPTCHA/screenshot analysis uses autogrammar-nlp2cmd/vision instead of a private OpenRouter model slug. Text generation is unchanged.
|
Naprawiono i zweryfikowano PR: zależność SubLLM wymaga Pythona 3.11+, więc zaktualizowano deklarację pakietu, macierz CI i dokumentację. Poprawiono też is_configured, aby sprawdzał realną gotowość klienta (klucz + zainstalowany transport), zamiast odrzucać poprawny klucz w zależności od lokalnej listy tras. CI bieżącego HEAD jest zielone: Python 3.11 i 3.12 — instalacja, pełne testy oraz lint. PR pozostaje nie scalony, ponieważ main nie ma rulesetu/ochrony gałęzi, a aktualny HEAD nie otrzymał zaufanego review. |
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Validator approval after policy checks for exact head 10769a4c90b467acb96c50e4c0250acb0e2a5bf9.
Ticket: ticket-001
Correlation ID: local-autogrammar-nlp2cmd-pr-1-ticket-001
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). PR routes vision calls through the central SubLLM transport, pins the dependency to a new commit, updates Python floor to 3.11 consistently (CI matrix, README, mypy, docs), and adds unit tests mocking subllm.complete. Required checks test (3.11) and test (3.12) both pass. No unresolved blocking or security concerns in the visible chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: satisfied; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: f3ea55f9c893007c3f1fdf0bce33c4b1628bb67d...10769a4c90b467acb96c50e4c0250acb0e2a5bf9
Change digest: 271a2347c856bfa674e5010901b490315225fae35a4955a57d1553ef8fdd1210
Score: 64/100 (L), estimated 82 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":62,"base_sha":"f3ea55f9c893007c3f1fdf0bce33c4b1628bb67d","binary_files":0,"categories":{"code":1,"configuration":2,"docs":3,"tests":2},"change_digest":"271a2347c856bfa674e5010901b490315225fae35a4955a57d1553ef8fdd1210","comparison":"f3ea55f9c893007c3f1fdf0bce33c4b1628bb67d...10769a4c90b467acb96c50e4c0250acb0e2a5bf9","deletions":41,"file_count":8,"files":["github/workflows/ci.yml","README.md","docs/README.md","project/ticket-001/README.md","pyproject.toml","src/nlp2cmd/llm/openrouter.py","tests/unit/test_automation.py","tests/unit/test_subllm_client.py"],"head_sha":"10769a4c90b467acb96c50e4c0250acb0e2a5bf9","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":82,"within_budget":false},"impact":{"components":["autogrammar-nlp2cmd","docs","github","project","repository-root","src/nlp2cmd","subactor","tests"],"files":["README.md","autogrammar-nlp2cmd/vision","docs/README.md","github/workflows/ci.yml","project/ticket-001/README.md","pyproject.toml","src/nlp2cmd/llm/openrouter.py","subactor/subllm","tests/unit/test_automation.py","tests/unit/test_subllm_client.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":10,"name":"Implement autogrammar-nlp2cmd","scope":["autogrammar-nlp2cmd"]},{"estimated_minutes":10,"name":"Implement docs","scope":["docs"]},{"estimated_minutes":10,"name":"Implement github","scope":["github"]},{"estimated_minutes":10,"name":"Implement project","scope":["project"]},{"estimated_minutes":10,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-001"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-001: feat: route nlp2cmd vision through central SubLLM</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 82m</text></svg>DECISION D-001-5746
TICKET ticket-001
HEAD_SHA 10769a4c90b467acb96c50e4c0250acb0e2a5bf9
CORRELATION_ID local-autogrammar-nlp2cmd-pr-1-ticket-001
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.12)=PASS","test (3.11)=PASS"]
INPUT required_checks = ["test (3.11)","test (3.12)"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/nlp2cmd","pull_request":1,"head_sha":"10769a4c90b467acb96c50e4c0250acb0e2a5bf9","base_sha":"f3ea55f9c893007c3f1fdf0bce33c4b1628bb67d","diff_sha256":"9cba007cdc0b45c75b44e3daa4768f67d6e1c6b3fbcf0e869e40de59a8df190b"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":true,"critical_paths":[".github/workflows/ci.yml"],"observed_paths":[".github/workflows/ci.yml","README.md","docs/README.md","project/ticket-001/README.md","pyproject.toml","src/nlp2cmd/llm/openrouter.py","tests/unit/test_automation.py","tests/unit/test_subllm_client.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"satisfied","reason":null,"review_sha256":"29cc9cfff5bc76493127f06dc6376600931a78462ba6c886c2998e018cf1cd21","unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"f3ea55f9c893007c3f1fdf0bce33c4b1628bb67d","head_sha":"10769a4c90b467acb96c50e4c0250acb0e2a5bf9","change_digest":"271a2347c856bfa674e5010901b490315225fae35a4955a57d1553ef8fdd1210","score":64,"complexity":"L","estimated_minutes":82,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
OpenRouterClient.visionnow calls SubLLMautogrammar-nlp2cmd/vision(image_url parts). Textcomplete()is unchanged.Depends on subactor/subllm#25. Unit tests mock
complete(); no paid requests.Ticket: ticket-001