Repository navigation
fix: classify malformed probe status as a failure - #13
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head 72d86d0193b9efa0315602b3e06869c956ff9d42.
Ticket: ticket-007
Correlation ID: curllm007-probe-status-20261006
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The PR correctly resolves an issue where unhashable malformed status types (lists, dicts) caused TypeError exceptions that interrupted the autonomy cycle, and ensures numeric and boolean statuses are properly classified as semantic failures rather than incorrectly passing. The intent, tests, and code implementation are well-aligned.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 473dcf782d67452a81da879830fde9927a4630b1...72d86d0193b9efa0315602b3e06869c956ff9d42
Change digest: 4165f6fb2ced6a5f945998c8fe017f7a6277bdce5434a3f9eb461fdc0e5e3e47
Score: 48/100 (M), estimated 51 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":105,"base_sha":"473dcf782d67452a81da879830fde9927a4630b1","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"4165f6fb2ced6a5f945998c8fe017f7a6277bdce5434a3f9eb461fdc0e5e3e47","comparison":"473dcf782d67452a81da879830fde9927a4630b1...72d86d0193b9efa0315602b3e06869c956ff9d42","deletions":2,"file_count":4,"files":["curllm_core/autonomy.py","project/ticket-007/README.md","project/ticket-007/intent.json","tests/test_autonomy.py"],"head_sha":"72d86d0193b9efa0315602b3e06869c956ff9d42","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":51,"within_budget":false},"impact":{"components":["curllm_core","project","tests","timeout"],"files":["curllm_core/autonomy.py","project/ticket-007/README.md","project/ticket-007/intent.json","tests/test_autonomy.py","timeout/descendant"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":11,"name":"Implement curllm_core","scope":["curllm_core"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":11,"name":"Implement timeout","scope":["timeout"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-007"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-007: fix: classify malformed probe status as a failure</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 51m</text></svg>DECISION D-007-4470
TICKET ticket-007
HEAD_SHA 72d86d0193b9efa0315602b3e06869c956ff9d42
CORRELATION_ID curllm007-probe-status-20261006
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","governance / enforce=PASS","metadata=PASS"]
INPUT required_checks = ["metadata","governance / enforce","governance / remote lifecycle"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/curllm","pull_request":13,"head_sha":"72d86d0193b9efa0315602b3e06869c956ff9d42","base_sha":"473dcf782d67452a81da879830fde9927a4630b1","diff_sha256":"e8512b63fe19bddc20825acb8e03662231a4f22f4d456fe54d8e1c0ac3efb088"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["curllm_core/autonomy.py","project/ticket-007/README.md","project/ticket-007/intent.json","tests/test_autonomy.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"473dcf782d67452a81da879830fde9927a4630b1","head_sha":"72d86d0193b9efa0315602b3e06869c956ff9d42","change_digest":"4165f6fb2ced6a5f945998c8fe017f7a6277bdce5434a3f9eb461fdc0e5e3e47","score":48,"complexity":"M","estimated_minutes":51,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Malformed application JSON such as
success:true,status:[]interrupted an autonomy cycle, while numeric and boolean status values could incorrectly pass. Validate the status field type before semantic classification so all four cases produce a failed probe.Validation: all four new regressions failed before repair; 30 autonomy tests pass after repair, including real process timeout/descendant cleanup, verified fixture repair and Planfile intake. Native governance passed.