fix(ci): regenerate schema + provision SCIM test allowlist + sign commit#265
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Auths Commit Verification
Result: ✅ 1/1 commits verified |
…sistence Fixes the CI failures surfaced by the #263 merge to main: 1. generate-schemas drift — regenerate schemas/identity-bundle-v1.json for the `kel: Vec<Event>` + `kel_attachments` change (#263 P3.1). The `kel` items now `$ref` the Event definition (+ CesrKey/Seal/Threshold/… deps) instead of `items: true`. 2. auths-scim-server (15 failures, 403/empty) — B.1/RT-006 made the SCIM capability allowlist deny-by-default, but the test harness `state_with_fake` (and the bespoke unknown-org test) provisioned none, so every CRUD op was denied. Opt them into `with_allow_all(true)` (the allowlist filtering is unit-tested in auths-scim) and add `joiner_with_disallowed_capability_is_denied` for server-level deny coverage. 3. rotation attachment persistence (test_verify_old_commit_after_rotation e2e) — apply_rotation appended the rot via `append_event`, so the rotation event had no stored CESR signature attachment and `id export-bundle` aborted after a rotation ("KEL event at seq N has no stored signature attachment"). Now finalize_rotation_storage signs the rot with the new current key and apply_rotation stores it via `append_signed_event` (RT-002), matching the existing rotate_keys_with_backend path. verify-commits: this commit carries Auths-Id/Auths-Device trailers (backfilled with `auths sign`, as this worktree has no prepare-commit-msg hook). Auths-Id: did:keri:ELv6uW2irGkclnFq8lAsAexmoLwZ-3k-ocwjpFBZsIEG Auths-Device: did:keri:ELv6uW2irGkclnFq8lAsAexmoLwZ-3k-ocwjpFBZsIEG
bordumb
force-pushed
the
fix/ci-schema-scim-trailers
branch
from
d38a064 to
9a349d9
Compare
Auths Commit Verification
Result: ✅ 1/1 commits verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three CI failures from the #263 merge to
main.1.
generate-schemasdriftschemas/identity-bundle-v1.jsonregenerated for thekel: Vec<Event>+kel_attachmentschange (#263 P3.1). Thekelitems now$reftheEventdefinition (and itsCesrKey/Seal/Threshold/… deps) instead ofitems: true, andkel_attachmentsis added. Matchescargo run -p xtask -- generate-schemas.2.
auths-scim-server— 15 test failures (403 / empty lists)B.1 / RT-006 made the SCIM capability allowlist deny-by-default, but the test harness
state_with_fakeprovisioned no allowlist, so every CRUD op was denied (403) and the list/get tests saw zero results.state_with_fake(and the bespokeunknown_org_tenant_…tenant) opt intowith_allow_all(true)— these tests exercise provisioning/CRUD, not the allowlist (which is unit-tested inauths-scim).joiner_with_disallowed_capability_is_deniedto keep server-level deny coverage (restrictive allowlist → out-of-list capability → 403).cargo test -p auths-scim-server: 20 passed.3.
verify-commits— missing Auths trailersThe #263 commits got the SSH signature but no
Auths-Id/Auths-Devicetrailers (noprepare-commit-msghook in the worktree). This branch's commit was backfilled withauths sign, so it carries the trailers + signature. Local check against the committed CI bundle: