Skip to content

feat(management): add agents, org clients, network ACL keys, and org role groups - #842

Merged
developerkunal merged 1 commit into
mainfrom
feat/agents-org-clients-network-acls
Aug 5, 2026
Merged

feat(management): add agents, org clients, network ACL keys, and org role groups#842
developerkunal merged 1 commit into
mainfrom
feat/agents-org-clients-network-acls

Conversation

@developerkunal

Copy link
Copy Markdown
Contributor

🔧 Changes

Adds new endpoints and their backing types to the management API.

  • Agents: new Agents client with List (cursor-paginated), Create, Read, Delete, and Update for managing agents.
  • Organizations → Clients: new Organizations.Clients client with List (checkpoint-paginated), Create, Delete, Get, and Update for managing organization-client associations. Organization responses now expose is_app_entitlement_active and client.
  • Organizations → Roles → Groups: new Organizations.Roles.Groups client with List to retrieve groups assigned to a role within an organization.
  • Keys → Network ACLs: new Keys.NetworkACLs client with Create for keys used to verify HTTP Message Signatures on Network ACL rules.
  • Connections → Directory Provisioning: adds AddSynchronizedGroupSelections and DeleteSynchronizedGroupSelections.
  • Roles: role responses now expose type (RoleTypeEnum) and owner_id.

Fixes

  • EventStreams.Deliveries.List now decodes the deliveries list and next cursor from the response object and returns a *core.Page[...]. Previously it decoded the response directly into a slice, which did not match the endpoint's actual payload, so the next cursor was never surfaced and pagination did not work.

📚 References

None

🔬 Testing

Covered by new and updated unit tests across management (new agents_test, organizations_clients_test, organizations_roles_groups_test, keys_network_acls_test, plus updates to types_test.go, requests_test.go, and the directory provisioning, organizations, roles, and event-stream delivery tests) and the updated wiremock mappings. go build ./... and go vet ./management/... both pass.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal
developerkunal requested a review from a team as a code owner August 5, 2026 05:13
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.38646% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.05%. Comparing base (d5be753) to head (1665cbf).

Files with missing lines Patch % Lines
management/types.go 88.71% 76 Missing and 45 partials ⚠️
management/agents.go 88.65% 10 Missing and 6 partials ⚠️
management/agents/client.go 90.09% 5 Missing and 5 partials ⚠️
management/organizations/clients/client.go 90.74% 5 Missing and 5 partials ⚠️
management/agents/raw_client.go 95.06% 4 Missing and 4 partials ⚠️
management/organizations/clients/raw_client.go 95.26% 4 Missing and 4 partials ⚠️
...connections/directoryprovisioning/client/client.go 80.00% 2 Missing and 2 partials ⚠️
...ections/directoryprovisioning/client/raw_client.go 94.73% 2 Missing and 2 partials ⚠️
management/keys/networkacls/client.go 90.47% 1 Missing and 1 partial ⚠️
management/keys/networkacls/raw_client.go 95.83% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   87.01%   87.05%   +0.03%     
==========================================
  Files         389      398       +9     
  Lines      181772   184157    +2385     
==========================================
+ Hits       158164   160310    +2146     
- Misses      17698    17863     +165     
- Partials     5910     5984      +74     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@developerkunal
developerkunal merged commit dbaffdf into main Aug 5, 2026
6 checks passed
@developerkunal
developerkunal deleted the feat/agents-org-clients-network-acls branch August 5, 2026 05:24
@developerkunal developerkunal mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants