Skip to content

Commit 7b62d31

Browse files
Coly Lidavem330
authored andcommitted
net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send
If a page sent into kernel_sendpage() is a slab page or it doesn't have ref_count, this page is improper to send by the zero copy sendpage() method. Otherwise such page might be unexpected released in network code path and causes impredictable panic due to kernel memory management data structure corruption. This path adds a WARN_ON() on the sending page before sends it into the concrete zero-copy sendpage() method, if the page is improper for the zero-copy sendpage() method, a warning message can be observed before the consequential unpredictable kernel panic. This patch does not change existing kernel_sendpage() behavior for the improper page zero-copy send, it just provides hint warning message for following potential panic due the kernel memory heap corruption. Signed-off-by: Coly Li <colyli@suse.de> Cc: Cong Wang <amwang@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: David S. Miller <davem@davemloft.net> Cc: Sridhar Samudrala <sri@us.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c381b07 commit 7b62d31

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

net/socket.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3638,9 +3638,11 @@ EXPORT_SYMBOL(kernel_getpeername);
36383638
int kernel_sendpage(struct socket *sock, struct page *page, int offset,
36393639
size_t size, int flags)
36403640
{
3641-
if (sock->ops->sendpage)
3641+
if (sock->ops->sendpage) {
3642+
/* Warn in case the improper page to zero-copy send */
3643+
WARN_ONCE(!sendpage_ok(page), "improper page for zero-copy send");
36423644
return sock->ops->sendpage(sock, page, offset, size, flags);
3643-
3645+
}
36443646
return sock_no_sendpage(sock, page, offset, size, flags);
36453647
}
36463648
EXPORT_SYMBOL(kernel_sendpage);

0 commit comments

Comments
 (0)