Skip to content

Commit c381b07

Browse files
Coly Lidavem330
authored andcommitted
net: introduce helper sendpage_ok() in include/linux/net.h
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a corrupted kernel heap, because these pages are incorrectly freed in network stack as page_count 0 pages. This patch introduces a helper sendpage_ok(), it returns true if the checking page, - is not slab page: PageSlab(page) is false. - has page refcount: page_count(page) is not zero All drivers who want to send page to remote end by kernel_sendpage() may use this helper to check whether the page is OK. If the helper does not return true, the driver should try other non sendpage method (e.g. sock_no_sendpage()) to handle the page. Signed-off-by: Coly Li <colyli@suse.de> Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Cc: Jan Kara <jack@suse.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Mikhail Skorzhinskii <mskorzhinskiy@solarflare.com> Cc: Philipp Reisner <philipp.reisner@linbit.com> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Vlastimil Babka <vbabka@suse.com> Cc: stable@vger.kernel.org Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f30e25a commit c381b07

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

include/linux/net.h

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <linux/rcupdate.h>
2222
#include <linux/once.h>
2323
#include <linux/fs.h>
24+
#include <linux/mm.h>
2425
#include <linux/sockptr.h>
2526

2627
#include <uapi/linux/net.h>
@@ -286,6 +287,21 @@ do { \
286287
#define net_get_random_once_wait(buf, nbytes) \
287288
get_random_once_wait((buf), (nbytes))
288289

290+
/*
291+
* E.g. XFS meta- & log-data is in slab pages, or bcache meta
292+
* data pages, or other high order pages allocated by
293+
* __get_free_pages() without __GFP_COMP, which have a page_count
294+
* of 0 and/or have PageSlab() set. We cannot use send_page for
295+
* those, as that does get_page(); put_page(); and would cause
296+
* either a VM_BUG directly, or __page_cache_release a page that
297+
* would actually still be referenced by someone, leading to some
298+
* obscure delayed Oops somewhere else.
299+
*/
300+
static inline bool sendpage_ok(struct page *page)
301+
{
302+
return !PageSlab(page) && page_count(page) >= 1;
303+
}
304+
289305
int kernel_sendmsg(struct socket *sock, struct msghdr *msg, struct kvec *vec,
290306
size_t num, size_t len);
291307
int kernel_sendmsg_locked(struct sock *sk, struct msghdr *msg,

0 commit comments

Comments
 (0)