Skip to content

Commit 0fbe2fe

Browse files
Leo Yanacmel
authored andcommitted
perf c2c: Use more explicit headers for HITM
Local and remote HITM use the headers 'Lcl' and 'Rmt' respectively, suppose if we want to extend the tool to display these two dimensions under any one metrics, users cannot understand the semantics if only based on the header string 'Lcl' or 'Rmt'. To explicit express the meaning for HITM items, this patch changes the headers string as "LclHitm" and "RmtHitm", the strings are more readable and this allows to extend metrics for using HITM items. Signed-off-by: Leo Yan <leo.yan@linaro.org> Tested-by: Joe Mario <jmario@redhat.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Link: https://lore.kernel.org/r/20201014050921.5591-6-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent fdd32d7 commit 0fbe2fe

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tools/perf/builtin-c2c.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,15 +1336,15 @@ static struct c2c_dimension dim_tot_hitm = {
13361336
};
13371337

13381338
static struct c2c_dimension dim_lcl_hitm = {
1339-
.header = HEADER_SPAN_LOW("Lcl"),
1339+
.header = HEADER_SPAN_LOW("LclHitm"),
13401340
.name = "lcl_hitm",
13411341
.cmp = lcl_hitm_cmp,
13421342
.entry = lcl_hitm_entry,
13431343
.width = 7,
13441344
};
13451345

13461346
static struct c2c_dimension dim_rmt_hitm = {
1347-
.header = HEADER_SPAN_LOW("Rmt"),
1347+
.header = HEADER_SPAN_LOW("RmtHitm"),
13481348
.name = "rmt_hitm",
13491349
.cmp = rmt_hitm_cmp,
13501350
.entry = rmt_hitm_entry,
@@ -1486,7 +1486,7 @@ static struct c2c_dimension dim_percent_hitm = {
14861486
};
14871487

14881488
static struct c2c_dimension dim_percent_rmt_hitm = {
1489-
.header = HEADER_SPAN("----- HITM -----", "Rmt", 1),
1489+
.header = HEADER_SPAN("----- HITM -----", "RmtHitm", 1),
14901490
.name = "percent_rmt_hitm",
14911491
.cmp = percent_rmt_hitm_cmp,
14921492
.entry = percent_rmt_hitm_entry,
@@ -1495,7 +1495,7 @@ static struct c2c_dimension dim_percent_rmt_hitm = {
14951495
};
14961496

14971497
static struct c2c_dimension dim_percent_lcl_hitm = {
1498-
.header = HEADER_SPAN_LOW("Lcl"),
1498+
.header = HEADER_SPAN_LOW("LclHitm"),
14991499
.name = "percent_lcl_hitm",
15001500
.cmp = percent_lcl_hitm_cmp,
15011501
.entry = percent_lcl_hitm_entry,

0 commit comments

Comments
 (0)