Skip to content

Commit fdd32d7

Browse files
Leo Yanacmel
authored andcommitted
perf c2c: Change header from "LLC Load Hitm" to "Load Hitm"
The metrics "LLC Load Hitm" contains two items: one is "local Hitm" and another is "remote Hitm". "local Hitm" means: L3 HIT and was serviced by another processor core with a cross core snoop where modified copies were found; it's no doubt that "local Hitm" belongs to LLC access. But for "remote Hitm", based on the code in util/mem-events, it's the event for remote cache HIT and was serviced by another processor core with modified copies. Thus the remote Hitm is a remote cache's hit and actually it's LLC load miss. Now the display format gives users the impression that "local Hitm" and "remote Hitm" both belong to the LLC load, but this is not the fact as described. This patch changes the header from "LLC Load Hitm" to "Load Hitm", this can avoid the give the wrong impression that all Hitm belong to LLC. Signed-off-by: Leo Yan <leo.yan@linaro.org> Tested-by: Joe Mario <jmario@redhat.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Link: https://lore.kernel.org/r/20201014050921.5591-5-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 6d662d7 commit fdd32d7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/builtin-c2c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1328,7 +1328,7 @@ static struct c2c_dimension dim_iaddr = {
13281328
};
13291329

13301330
static struct c2c_dimension dim_tot_hitm = {
1331-
.header = HEADER_SPAN("----- LLC Load Hitm -----", "Total", 2),
1331+
.header = HEADER_SPAN("------- Load Hitm -------", "Total", 2),
13321332
.name = "tot_hitm",
13331333
.cmp = tot_hitm_cmp,
13341334
.entry = tot_hitm_entry,

0 commit comments

Comments
 (0)