Conversation
Author
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #1510
Summary
This pull request enhances the post body editor by making the formatting toolbar sticky (pinned) at the top while scrolling, and adds comprehensive end-to-end tests to verify this behavior in both normal and focus modes. The main changes include UI updates for the sticky toolbar, new Playwright tests, and supporting test helpers.
Sticky toolbar implementation and styling:
EditorToolbarcontainer inPostBodyEditor.tsxto useposition: sticky, add a background, rounded corners, and z-index to ensure it stays pinned at the top of the editor during scrolling.Automated end-to-end testing:
editor-toolbar.spec.ts), used to verify that the toolbar remains pinned while scrolling the post body, both in standard and focus modes.helpers/posts.tsto support filling the editor with enough content to enable scrolling, entering/exiting focus mode, and asserting that the toolbar remains pinned and interactive during scroll events.Test Results
Existing issues remain untouched.
No composer tests were run since this was a UI-specific change.