Repository navigation
fix: support Omarchy installation and resolve validation failures - #107
Merged
Merged
Conversation
Resolve Linux dependency recipes through a shared os-release reader. Keep explicitly supported distribution IDs authoritative, and use the Arch recipe only when an otherwise unsupported host declares an exact arch token in ID_LIKE. Clear inherited release fields so absent metadata remains unsupported. Add hermetic regression coverage for both profiles, supported recipe precedence, token matching, missing metadata, and dry-run preservation. Document the tested Arch prerequisites, automatic Omarchy setup, older-checkout workaround, and optional tool verification. Refs #106
Retry explicit zero-scan Binwalk exits within one deadline while retaining failed attempts. Use a printable tmux state delimiter, make native-architecture fixtures portable, isolate executable-copy tests, and satisfy current Clippy chunk lints.
adi0x90
marked this pull request as ready for review
September 25, 2026 11:48
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #106. Omarchy (
ID=omarchy,ID_LIKE=arch) now uses the Arch dependency recipe, with a complete Arch/Omarchy installation guide. Follow-up validation also exposed a Binwalk startup race and a tmux 3.7c compatibility bug; both are handled without weakening the extraction or session-reuse assertions.Changes
archtoken inID_LIKE, retaining explicitly supported distro recipes.master.Verification
Focused regressions passed after reproducing failures for Binwalk zero-scan recovery, retry exhaustion, shared deadlines, nested log placement, and tmux control-character sanitization. The real Binwalk 3.1.0 failure reproduced in 34/400 concurrent benign fixture scans on the Omarchy VM.
Final validation of commit
3ea9d21a69e5895f6b911111c3d8d6dcd5d22410:Full locked workspace: 1,963 passed, 0 failed, 0 ignored on macOS/Rust 1.94 and independently on Omarchy/Rust 1.94, using normal parallel test execution.
Clean formatting and warnings-as-errors Clippy (
--workspace --all-targets --all-features --locked -- -D warnings) on both hosts.All 16 installer regressions, all four kernel-profile tests, and runtime-data bundle verification passed.
GitHub checks: all five native builds and five archive smoke jobs passed; Linux archives also passed Fedora checks. Publishing jobs were skipped.
Installation guide: 12 Bash blocks passed syntax checks; local installation-guide links resolved and GitHub-rendered tables/code blocks were checked.
Rust 1.98.1 analyzer Clippy also passed with all analyzer test targets and warnings treated as errors.
Both real
--install-system-depsprofiles (core and extraction) passed on Omarchy in separate prefixes, followed by data verification and strict doctor outside the checkout.40/40 synthetic extraction repetitions passed. An injected zero-scan result recovered through the real Binwalk on retry; the manifest recorded the retry and recovered marker contents matched.
The comprehensive live VM checks completed at 11:57:15 UTC on 25 September 2026 at
f3ef42a. The final head changes only two test-fixture loops; its full workspace, formatting, and Clippy recheck passed on both hosts, finishing at 12:12:13 UTC on Omarchy. All 752 final source-file hashes matched the committed snapshot.Final host audit: no kernel OOM events or remaining validation processes; the original baseline checkout and installed binary are unchanged, and the remote desktop service remains inactive.
The original soak and its failure evidence are retained. The tests use synthetic software fixtures; no real device firmware boot was tested. Native unblob still requires additional format-specific extractors as documented in the guide.