Skip to content

fix(protocol): use Classic command permissions for access - #47

Merged
zoeyrose merged 1 commit into
mainfrom
fix/access-command-permission
Oct 4, 2026
Merged

zoeyrose merged 1 commit into
mainfrom
fix/access-command-permission

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Align Classic access-code administration with its existing per-player/character command permissions. /access uses /cmd_permission, and [OP] grants it automatically like other operator commands.

Implementation / behavior

  • Check the active character's effective command permission on each operation.
  • Remove the separate root-managed account allowlist and access-specific authority requirement.
  • Preserve existing account passwords, stored character permissions and the checked serialized token store.
  • Retain root-only Unix-socket administration for a locked private server's initial code, and keep access policy/store-path configuration startup-only.

Only spec/access-tokens.md changes. Wire identities, schemas, generated bindings, crate sources, fixtures and publication policy are unchanged. The separate registry-publication proposal in #46 is untouched.

Validation

At 868a5cddaaaec9be264c414783182c51393b08e9, independent review approved the complete specification change. Full tools/validate.sh passed in pinned Linux build image sha256:7904a1802054662b0ede5b55de72e4c92b0112a3c211125f994ed6c62e9ec9d8; regeneration left the tree clean and full-base whitespace checks passed. Required GitHub checks Protocol validation and Conventional PR title passed on this exact head and accepted base.

Limitations / follow-up

Classic owns the command dispatcher and per-character permission implementation, which are being updated separately. This source change performs no deployment, crate preparation, registry operation or merge.

@zoeyrose
zoeyrose marked this pull request as ready for review October 4, 2026 19:55
@zoeyrose
zoeyrose merged commit 6a725ca into main Oct 4, 2026
9 checks passed
@zoeyrose
zoeyrose deleted the fix/access-command-permission branch October 4, 2026 21:48
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant