Repository navigation
fix(protocol): prohibit address-based access tracking - #45
Merged
Merged
Conversation
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove address-based requester tracking from the access-token contract. The former source-HMAC rate-limiting requirement conflicts with keeping player IP addresses out of application identity and usage records.
Implementation / behavior
Only
spec/access-tokens.mdchanges. Protobuf schemas, generated Go/Rust bindings, crate sources, fixtures and publication policy are unchanged.Validation
At
79f9511140dfd0a203ea7642c821a012d7c3d41d, fulltools/validate.shpassed in the pinned Atrinik Linux build imagesha256:7904a1802054662b0ede5b55de72e4c92b0112a3c211125f994ed6c62e9ec9d8. Regeneration left the tree clean, unchanged generated/consumer inputs were verified, and the full-base whitespace check passed.Independent review approved this exact head. Required GitHub checks
Protocol validationandConventional PR titlepassed on this head and accepted base.Limitations / follow-up
Metaserver and Classic implementation changes are coordinated separately under #43; this specification does not claim those runtime changes are deployed. The metaserver shared capacity defaults need their own implementation/load review.
Crate preparation remains undispatched. Its exact source-release target must be reconsidered after the privacy contract is finalized, even though generated library bytes are unchanged. No merge, registry publication, provider configuration or production change is included.