fix(workflows): scope merged PR versioning - #217
TorinAsakura wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40bd0bb729
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exit 1 | ||
| fi | ||
|
|
||
| if ! git checkout -B master "$GITHUB_SHA"; then |
There was a problem hiding this comment.
When another PR or version commit reaches master after this event's GITHUB_SHA but before this job pushes, this command leaves the local master fixed at the older event commit. The later EndBug/add-and-commit step specifies only branch: master and no pull/rebase behavior, so its normal push is rejected as non-fast-forward and this PR's deferred version changes are never recorded (git push -h confirms force updates require the explicit --force option). Preserve the frozen workspace set, but apply its generated changes on top of the latest remote master before committing and pushing.
Useful? React with 👍 / 👎.
1 participant
Таска
Как проверять
Основной сценарий
pull_request: closedworkflow вatls/serenityпосле merge.Действие: запустить version job с event base SHA и merged
GITHUB_SHA.Ожидаемый результат: workflow точечно получает merged head, проверяет base/head и ancestry, а Yarn выбирает non-private workspaces относительно exact PR base до
version apply --all.Дополнительный сценарий
Действие: выполнить тот же version job.
Ожидаемый результат: deferred patch завершается наблюдаемым no-op; недоступный source, невалидная ancestry или ошибка Yarn завершают job до version mutation.
Пруфы
actionlint .github/workflows/version.yaml: проходит без ошибок.fetch-depthи полной истории;merge-baseравен exact base, commit до base отсутствует.1e847e525010823e17206d0b488b7c764a34898f4d6534f2b3941bed1bc7d137.git diff --check: проходит; diff ограничен.github/workflows/version.yaml.