Feat/icons generation reproducibility check - #716
Conversation
TorinAsakura
left a comment
TorinAsakura
left a comment
There was a problem hiding this comment.
кажется слой ui-admin/icons/scripts/ давно уже перерос в lib как минимум, нужна реорганизация
|
TorinAsakura
left a comment
TorinAsakura
left a comment
There was a problem hiding this comment.
Архитектурный контур не проходит: проверочный сценарий и роли файлов разложены не по владельцу ответственности
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 059224bc13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d778bc5631
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afb9201d90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Таска
Как проверять
Контекст: локальная проверка воспроизводимости генерации
@atls-ui-admin/iconsДействие: выполнить
yarn workspace @atls-ui-admin/icons check-generatedОжидаемый результат: команда завершается успешно, выводит
Generated icons are up to date, рабочее дерево после запуска остаётся чистымКонтекст: негативная проверка drift сгенерированных icon-компонентов
Действие: временно изменить любой файл в
ui-admin/icons/src/icons, например заменить одинcurrentColorвbag.icon.tsx, затем выполнитьyarn workspace @atls-ui-admin/icons check-generatedОжидаемый результат: команда падает с ошибкой
Generated files are outdatedи указывает изменённый файл какcontent differsКонтекст: сборка затронутых пакетов
Действие: выполнить
yarn workspace @atls-ui-admin/icons buildиyarn workspace @atls-ui-generators/icons buildОжидаемый результат: обе сборки завершаются успешно
Пруфы
Details