CI builds & looser device-name check - #7
Open
konsumer wants to merge 38 commits into
Open
Conversation
Author
Still needs testing on windows, which will take me a bit (have to setup a virtual-machine) but this gives me new stuff to troubleshoot. |
added 2 commits
December 26, 2022 18:38
Author
|
Update: just needed joystick mapping to make RG353P work. Here is what I landed on: {
"joysticks": {
"190000004b4800000111000000010000": {
"buttons": {
"15": "Left",
"16": "Right",
"8": "Escape",
"14": "Down",
"0": "Option",
"1": "Edit",
"2": "Play",
"17": "Escape",
"3": "Shift",
"13": "Up",
"9": "Config"
},
"axes": {
"4": {
"sensibility": 20000
},
"5": {
"sensibility": 20000
},
"3": {
"sensibility": 20000
},
"2": {
"sensibility": 20000
},
"0": {
"negative": "Left",
"positive": "Right",
"sensibility": 20000
},
"1": {
"negative": "Up",
"positive": "Down",
"sensibility": 20000
}
}
}
}
}Runs great, with audio. |
uses docker for linux for much better build
Author
|
Another idea, instead of releases, is using nightly.link to link to build-assets. I could merge the 2 ideas together, so you get bleeding-edge builds, but can also do tagged releases. |
Author
|
I merged the other PR here, so I can keep working on stuff. |
Closed
Append the user to the given group instead of removing all other groups not listed (including wheel) which can result in using sudo rights.
Fix Devices readme
Add rg353v config and update DEVICES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This will build several pre-compiled releases in Github CI (#6)
The idea is that it's triggered with a semver git-tag (like
v0.0.1) but we can set it up some other way, if this is not convenient. For testing, I used dummy tags likevtest24. If you don't want to use semver, I think any tag could also trigger it, with a small change (so you can just tag your releases and it will generate a release for it.)Currently, it can build:
It will add a new tagged release with assets so users can download the built runtime for their platform (including some config examples and the README.)
This should have pi and handheld Anberinic devices (like this) covered, as well as windows, and older macs. I need to do more testing. I have a Mac M1, and an Intel-mac, and a few different platforms for linux, so I will try to get those all verified (and windows, in a vmachine.)
Linux cross-building is very slow, since it builds in qemu. I think we could improve this using rust's cross-building stuff, but it seems a bit tricky with SDL2/libudev native deps.
Main build-things left to do is mac arm64 (for M1/M2 apple silicone) and I can't seem to get it, but I made an issue over here asking for help. There is also currently an error trying to cross-build on linux
spurious network error - Value too large for defined data type; class=Os (2)which I need to look into. It just started doing this, so maybe I need to adjust something in the docker-build.I think for mac/linux, users will probly also need instructions for installing SDL, since it's dynamically-linked. For windows, I include a SDL2.dll in build.