Skip to content

Compatibility with pytest 9.1 - #241

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:pytest-9.1
Jul 31, 2026
Merged

Compatibility with pytest 9.1#241
pllim merged 1 commit into
astropy:mainfrom
pllim:pytest-9.1

Conversation

@pllim

@pllim pllim commented Jun 23, 2026

Copy link
Copy Markdown
Member

Revert #240

Fix #239

Please squash and merge.

@pllim pllim added this to the v0.23.0 milestone Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (7ef8f16) to head (22afea1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   89.49%   89.50%           
=======================================
  Files          31       31           
  Lines        1257     1258    +1     
=======================================
+ Hits         1125     1126    +1     
  Misses        132      132           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim
pllim marked this pull request as ready for review June 23, 2026 21:11
- os: ubuntu-latest
python-version: '3.14'
toxenv: py314-test-sphinxdev
posargs: -v

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would give me verbose output but it does not seem to work. 🤷‍♀️

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, it's not being passed on anywhere, but honestly, just add it to the actual pytest line in the tox file, it wouldn't hurt to be always verbose.

@pllim
pllim requested a review from bsipocz June 23, 2026 21:12

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If you don't mind please squash out the reverts and fix up the verbose commit, then this can go in.

- os: ubuntu-latest
python-version: '3.14'
toxenv: py314-test-sphinxdev
posargs: -v

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, it's not being passed on anywhere, but honestly, just add it to the actual pytest line in the tox file, it wouldn't hurt to be always verbose.

TST: Remove pytest max pin

TST: Also test pytest-dev with sphinx-dev

TST: Verbose output for one job

isolated_build not used after tox 4
@pllim

pllim commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Squashed and rebased. 🤞

@pllim
pllim merged commit cbbd087 into astropy:main Jul 31, 2026
20 checks passed
@pllim
pllim deleted the pytest-9.1 branch July 31, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: temporarily failures due to pytest 9.1 incompatibilities

2 participants