Add covers method and make contains boundary semantics consistent - #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Region
containsmethods were inconsistent at the boundary:EllipsePixelRegion.containsincluded it,Circle/Rectangleexcluded it, andPolygonPixelRegion.containswas ambiguous on edges/vertices.This PR makes
containsstrictly exclude the boundary for all pixel regions (matching Shapely'scontainsand DE-9IM) and adds a newcoversmethod that includes the boundary (matching Shapely'scovers). The polygon implementation gains an explicit point-on-segment test, and the subpixel mask sampler uses the boundary-inclusive variant.The
containsmethods of all regions now also ignore the'include'metadata attribute (which was previously used to invert evaluation results), making containment and covering behavior depend solely on the geometric shape of the region.