DOC: making sure doctests pass more often - #694
Conversation
msdemlei
left a comment
There was a problem hiding this comment.
Hm... I kind of like it if we show the phase progression. I'd say that particular service isn't well suited for this test because it occasionally is loaded, and then jobs may be QUEUED for a long, long time.
On the other hand, there is http://voparis-rr.obspm.fr/tap, which is also likely to stay around (it's part of the reg.g-vo.org mirror system) and that should basically never have long-running jobs. Perhaps the code tested should be modified to do something like this:
tap_service = vo.dal.TAPService("http://voparis-rr.obspm.fr/tap")
ex_query = """
SELECT TOP 10 ivoid, res_title
FROM rr.resource
"""
async_job = tap_service.submit_job(ex_query)
async_job.run().wait()
For robustness, I think we should be explicitly waiting for COMPLETED (but with a short timeout), though.
I'd be happy to add HTTPS support to voparis-rr if that makes the decision simpler.
|
OK, I've gone now the other way, added a full, non ellipsed example and ignore the specifics. |
L385 kept failing in CI