Skip to content

DOC: making sure doctests pass more often - #694

Merged
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:DOC_ignore_doctest_output
Aug 25, 2025
Merged

DOC: making sure doctests pass more often#694
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:DOC_ignore_doctest_output

Conversation

@bsipocz

@bsipocz bsipocz commented Aug 10, 2025

Copy link
Copy Markdown
Member

L385 kept failing in CI

@bsipocz bsipocz added this to the v1.7.1 milestone Aug 10, 2025

@msdemlei msdemlei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I kind of like it if we show the phase progression. I'd say that particular service isn't well suited for this test because it occasionally is loaded, and then jobs may be QUEUED for a long, long time.

On the other hand, there is http://voparis-rr.obspm.fr/tap, which is also likely to stay around (it's part of the reg.g-vo.org mirror system) and that should basically never have long-running jobs. Perhaps the code tested should be modified to do something like this:

tap_service = vo.dal.TAPService("http://voparis-rr.obspm.fr/tap")
ex_query = """
SELECT TOP 10 ivoid, res_title
FROM rr.resource
"""
async_job = tap_service.submit_job(ex_query)
async_job.run().wait()

For robustness, I think we should be explicitly waiting for COMPLETED (but with a short timeout), though.

I'd be happy to add HTTPS support to voparis-rr if that makes the decision simpler.

@bsipocz

bsipocz commented Aug 17, 2025

Copy link
Copy Markdown
Member Author

OK, I've gone now the other way, added a full, non ellipsed example and ignore the specifics.

@bsipocz
bsipocz merged commit 89c7022 into astropy:main Aug 25, 2025
11 checks passed
@bsipocz
bsipocz deleted the DOC_ignore_doctest_output branch August 25, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants