EUCLID: new method get_sia to access the Simple Image Access Protocol (SIAP) v2.0

[cosmoJFH]

Dear astroquery team,

we would like to implement a new method for the Simple Image Access Protocol (SIAP) v2.0 exposed by the Euclid project.

The Euclid Archive applies the following IVOA standard to serve:

1. Tables (catalogues), via the IVOA Table Access Protocol TAP
2. Spectra, via the IVOA DataLink prococol.
3. Images (and cutouts), via the Simple Image Access (SIA)

The new get_sia method will allow users to obtain the “file_name” and “file_path” of the FITS files that contain the observations of the input coordinates.

cc @esdc-esac-esa-int
jira: EUCLIDSWRQ-250

Note that this PR clones #3506, that was closed due to an error when updating the remote branch.

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.45%. Comparing base (477962f) to head (e0a1c95).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/esa/euclid/core.py	89.06%	7 Missing ⚠️
astroquery/utils/tap/core.py	50.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
+ Coverage   73.42%   73.45%   +0.03%     
==========================================
  Files         230      230              
  Lines       21360    21424      +64     
==========================================
+ Hits        15684    15738      +54     
- Misses       5676     5686      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cosmoJFH]

Hi @bsipocz, we’re planning to include this feature in the next release scheduled for the end of May. Would the team have time to review this pull request?

[cosmoJFH]

Hi @bsipocz,

We'd like to merge this new method into the develop branch because we need it for the DataLabs service. Would you have time to review the changes when you get a chance?

Thanks very much in advance!

[cosmoJFH]

Hi @bsipocz,

we’re planning to include this new feature in the next release scheduled for the end of July. Would the team have time to review this pull request?

[keflavich]

there are non-keyword arguments after a keyword argument. I thought this was syntactically disallowed?

We also prefer using coordinate (a skycoord) rather than manually specified ra/dec

[keflavich]

the order should be required positional arguments (e.g., coordinate, radius, search_type), then *, then keyword arguments.

[cosmoJFH]

The parameter coordinates accepts a str or SkyCoord, since it is parsed by the method commons.parse_coordinates.

We would like to define the parameters as keyword-only arguments, because get_sia has many optional arguments, and requiring keywords makes calls much more self-documenting. We do not set a default value for coordinates, so callers must provide the coordinates argument.

[keflavich]

this should be handled by standard astroquery coordinate handling mechanisms

[cosmoJFH]

We fully agree with you. We make use of the methods commons.parse_coordinates(coordinates=coordinates) and
esautils.get_degree_radius(radius)

[cosmoJFH]

Converted to a draft till is fully validated by our team.

[cosmoJFH]

The ESAC team has reviewed and tested the changes. We think that the PR is ready to be reviewed again by the Astroquery team. Thank you very much in advance.

[cosmoJFH]

Hi @bsipocz,

we’re planning to include this new feature in the next release of the DATALABS scheduled for the end of September. Would the team have time to review this pull request? Thank you very much in advance.