Fix icrs serialization selecting incorrect tag - #335
Open
braingram wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 99.06% 99.06% -0.01%
==========================================
Files 71 71
Lines 2572 2564 -8
==========================================
- Hits 2548 2540 -8
Misses 24 24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
braingram
marked this pull request as ready for review
August 13, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #334
Update icrs handling converters to correctly serialize using the latest tag instead of 1.0.0. Add test to confirm serialization uses a >1.0.0 tag.
Remove test_legacy_icrs_serialize that directly used a
LegacyICRSConverter.to_yaml_treewhich was never expected to be used based on the comment:asdf-astropy/asdf_astropy/converters/coordinates/frame.py
Lines 58 to 59 in 0b8f857
and with this PR is now unused (and removed).