Skip to content

Fix icrs serialization selecting incorrect tag - #335

Open
braingram wants to merge 3 commits into
astropy:mainfrom
braingram:fix_icrs
Open

Fix icrs serialization selecting incorrect tag#335
braingram wants to merge 3 commits into
astropy:mainfrom
braingram:fix_icrs

Conversation

@braingram

Copy link
Copy Markdown
Contributor

Fixes: #334

Update icrs handling converters to correctly serialize using the latest tag instead of 1.0.0. Add test to confirm serialization uses a >1.0.0 tag.

Remove test_legacy_icrs_serialize that directly used a LegacyICRSConverter.to_yaml_tree which was never expected to be used based on the comment:

# Leave the types list empty so that the 1.1.0 ICRS converter
# is used on write.

and with this PR is now unused (and removed).

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.06%. Comparing base (0b8f857) to head (3300127).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files          71       71              
  Lines        2572     2564       -8     
==========================================
- Hits         2548     2540       -8     
  Misses         24       24              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram
braingram marked this pull request as ready for review August 13, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icrs frame incorrectly uses 1.0.0 tag

1 participant