Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/redline-fix.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Redline fix: when Redline requests changes on a pull request here, forge dispatches this run
# Redline fix: when Redline requests changes on a pull request here, the ops tick dispatches this run
# with the PR, the head Redline reviewed and the review. The fix itself is computed by
# askalf/ci (redline-fix-run.yml) on this repository's fix-lane runner and uploaded as
# the redline-fix artifact. Nothing here pushes or comments, and no token that could is on the
# runner: forge verifies the artifact and pushes the fix to the PR branch with its own token.
# runner: the ops tick verifies the artifact and pushes the fix to the PR branch with its own token.
name: Redline fix
run-name: Redline fix ${{ github.repository }}#${{ inputs.pr }} @ ${{ inputs.head }}

Expand Down Expand Up @@ -33,7 +33,7 @@ permissions:

# One group per review: GitHub keeps a single pending run per concurrency group and a newer
# dispatch replaces it, so a group shared across a PR's reviews could drop a review's run before
# it uploads the artifact forge reads. Runs for different reviews may overlap; each only reads
# it uploads the artifact the ops tick reads. Runs for different reviews may overlap; each only reads
# the PR and uploads its own artifact, and one whose head the PR has moved past fails on its own.
# A repeat dispatch of the same review queues behind the first.
concurrency:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/redline.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Redline, the gating code review, as this repo's CI check. The review itself lives in
# askalf/ci (redline-review.yml): read-only tools, verdict = pass or fail. On pull_request it reviews same-repo PRs.
# Forge also dispatches it on the default branch for a head the pull_request run cannot vouch for
# (a PR that changes CI, a verdict forge refused, a re-read after a description edit); that run
# The ops tick also dispatches it on the default branch for a head the pull_request run cannot vouch for
# (a PR that changes CI, a verdict the ops tick refused, a re-read after a description edit); that run
# executes the default branch's workflow files, not the PR's, and reviews the head it is given.
name: Redline
# Forge finds its dispatch by this title (platform runtime/redline-ci-dispatch.ts); keep it exact.
# The ops tick finds its dispatch by this title; keep it exact.
run-name: ${{ github.event_name == 'workflow_dispatch' && format('Redline review {0}#{1} @ {2}{3}', github.repository, inputs.pr, inputs.head, inputs.reread && ' (re-read)' || '') || github.event.pull_request.title }}

on:
Expand Down Expand Up @@ -35,7 +35,7 @@ permissions:

# On pull_request the newest push wins. A dispatch gets a group of its own per head and mode, and
# is never cancelled: a group holds one pending run and a newer one cancels it, and a cancelled
# dispatch leaves forge no verdict to read. Forge sends one dispatch per head and mode at a time.
# dispatch leaves the ops tick no verdict to read. The ops tick sends one dispatch per head and mode at a time.
concurrency:
group: redline-${{ github.event_name }}-${{ github.event.pull_request.number || inputs.pr }}${{ inputs.head && format('-{0}-{1}', inputs.head, inputs.reread) || '' }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Expand Down
Loading