[askalf]

Fixes an intermittent failure in test/keys-budget-proxy.mjs (the burst checks for dan, erin and gina).

Each admitted burst request was held at the stub for a fixed 400 ms so the burst overlapped at the budget check. On a loaded runner a burst request could reach that check after an admitted one had already completed, so it saw completed use instead of a reservation and the admitted count came out different from the expected one.

What changes:

• A burstOf(n, want, send) helper fires the burst and holds the admitted requests at the stub until all n - want refusals have come back. Every request is then decided while the admitted ones are still in flight, however slowly the runner delivers them.
• The expected count is computed before the burst fires, since the helper needs it.
• A 10 s timer releases the hold if the count is already wrong, so the check fails with the real statuses instead of hanging.

No product code changes. Ran the file three times locally: 53 passed, 0 failed each run.

Second fix, in test/keys-proxy.mjs: the proxy's presence heartbeat goes through the stubbed fetch every 5 s, and the stub recorded it like a routed request. A pulse landing between a reset of started and a check failed "nothing went upstream" (it can also skew the per-seat counts). The stub now answers presence pulses without recording them. Ran it twice locally: 68 passed, 0 failed.

[github-actions]

Live test: ✅ PASS

Head 0f3b7d6f65fc3b822d20c8abc730a86d5f7675db on the self-hosted runner: All stages PASS: install/build/cc-detect/cli/doctor/live-probe(pong)

Stages

install: PASS
build: PASS
cc-detect: PASS
cli: PASS
doctor: PASS (exit 1, 19 rows; no credentials, reported cleanly)
live: PASS (pong)

Full workflow run

[sprayberry-redline]

Verdict: approve. The burst helper keeps admitted requests in flight until the expected refusals have returned, and the upstream stub now excludes presence heartbeats from routed-request assertions. The tests retain their status-count assertions while avoiding timing-dependent completion ordering.

Minor:

• test/keys-budget-proxy.mjs:102: This comment narrates the prior timing failure and the patch history rather than only documenting the helper's current contract.