Repository navigation
ci: run the fleet status self-test on every pull request - #199
Merged
Merged
Conversation
github-actions
Bot
added
github_actions
askalf
enabled auto-merge (squash)
November 2, 2026 00:20
A required check that never reports holds the merge, and a paths filter means it never reports on a pull request that changes no workflow. The paths filter goes, so the full check runs on every pull request, and the check pin moves to askalf/ci#157, which accepts that trigger.
askalf
force-pushed
the
ci/self-test-every-pr
branch
from
November 2, 2026 00:23
b0b0d9d to
212167e
Compare
github-actions
Bot
added
size/XS
sprayberry-redline
approved these changes
Nov 2, 2026
sprayberry-redline
left a comment
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. Removing the paths filter lets self-test report on pull requests regardless of which files change, supporting its use as a required check. The job remains unconditional, with read-only contents access and commit-pinned actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet status self-test now runs on every pull request, so it can become a required check.
Until now the workflow ran only when a pull request touched
.github/workflows/**. A ruleset waits for every required check to report, and a workflow that a paths filter skips never reports, so requiring self-test as it was would hold every other pull request open.What changes:
pathsfilter is gone, so the full check runs on every pull request. Nothing in the job decides whether to skip it.if:.After merge, the default branch ruleset adds
self-testto its required checks.