Repository navigation
Conversation
Register independent DeepSeek CUDA settings and report explicit values without exposing path contents. Preserve defaults, supported boolean forms and canonical tool-grammar precedence. Refs #2370
ashhart
force-pushed
the
lead/dsv41-strict-env
branch
from
November 6, 2026 16:28
4de7e91 to
2e7c2a2
Compare
6 of 8 tasks
Keep all served row buckets and empty knob defaults, recognize named on/off forms, and reject a bad legacy grammar alias at server startup. Scope raw explicit identity values to the registered family and preserve every other family key. Refs #2370
4 of 8 tasks
6 of 9 tasks
3 of 4 tasks
Owner
Author
|
Held from tonight's landing queue, until after the 1.2.4 cut. This adds a second strict environment parser ( |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2370: DeepSeek-V4.1's
TF_DSV41_*settings on CUDA stop reading a bad value as something else.Refused by name, before loading. A setting that used to fall back to a default, or flip to the other state of a switch, on bad text now stops the server with the variable, the raw value and the accepted forms. The check runs at the start of
Model.open, before the experimental-family gate, any allocation, device setup or checkpoint access, and at the start of the AOT planner (families/deepseek_v41/env_validate.zig,cuda_model.zig,aot_needs.zig). It covers 48 switches, 14 integer settings, 16 real-valued settings and 3 structured ones. The readers themselves use the same parser (platform/strict_env.zig), so a later direct read refuses rather than coercing too.Valid values read as before:
0and1everywhere. The forms some readers already took (true/false,on/off,yes/no, an empty string for off) are kept where they were.BIAS_VLkeeps its presence meaning (0and1both select the bias; unset or blank is off).TENSORFOLD_TOOL_GRAMMARstill takes precedence over its DeepSeek alias.Two settings change, both from silently wrong to named (see the revision below for the rest):
TF_DSV41_FLOOR_HARD_GIBhad two readers that disagreed: one made a bad value 4 GiB, the other refused it. It now has one reader in the KV budget, shared by boot admission, graph room, the scheduler and the 4K workspace. Unset is still 4 GiB.TF_DSV41_ENGRAM_READERSabove 32 is refused instead of clamped.Registry. Twenty
deepseek_v41/CUDA rows incore/profile.zig, one per independently settable variable, so explicit settings show on the startup line and in the disk-cache key. No default changes. The Engram path shows as<set>, never its value.docs/profiles.mdlists the rows.Checks
compile-cuda-tests -Dtarget=x86_64-linux-gnu). No touched file is over 600 lines, and lean has no new findings.We hold no DeepSeek checkpoint, so nothing here ran on a device. The change is in setting parsing and reporting only, with no kernel, arithmetic or default touched.
Revision (
0abc692e73), after an independent read:native/disk_identity.zignow handles the registry's newexplicitsyntax, which the native CUDA and Metal builds reach. Its key changes only fordeepseek_v41. The Linux native build, the Mac native build and the Metal disk-identity check all pass now. The first head's checks hadn't built them.true/on/yesandfalse/off/noas well as0and1, and other text is refused.TF_DSV41_ROWS_CAPtakes every bucket its reader takes (1-8, 12, 16, 24, 32, 48, 64). The served knobs again treat an empty value as unset.GRAPHS,OWN_PREFILL,DRAFTSand the others listed indocs/profiles.md) used to read as on, and is now refused by name.TF_DSV41_TOOL_GRAMMAR, the old alias ofTENSORFOLD_TOOL_GRAMMAR, is refused at server start on every family. A setTENSORFOLD_TOOL_GRAMMARstill masks it.zig build native -Dcpu=apple_m1(66 of 66);zig build -Dtarget=x86_64-linux-gnu(31 of 31).