Repository navigation
Tests: the 27B decode control edits #2106's masked line, so M5 contract runs finish - #2303
Merged
Merged
Conversation
Owner
Author
|
Checked on an M5 Ultra on this head with |
…ct runs reach their summary 9be323a gated the decode line on MASKED, and the decode control's edit still looked for the old text, so on M5 Attn.init returned ControlEdit and tf-kernel-contract stopped before any summary (#2301). Co-authored-by: BobClawblaw <288991054+BobClawblaw@users.noreply.github.com>
ashhart
force-pushed
the
lead/q27-control-2301
branch
from
November 6, 2026 13:48
03b1dcf to
23d87ef
Compare
Owner
Author
|
Thank you @BobClawblaw. This is merged into main with your commits under your own name, so you're credited as a TensorFold contributor. |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2301, found and diagnosed by @BobClawblaw.
#2106 (9be323a) gated the 27B's decode line on
MASKED(const bool masked = MASKED && q27_nonfinite(...)), but the decode control inzig/tests/contract/metal_q27_attn_rows.zigstill edited the old text. On an M5 it found no match, soAttn.initreturnederror.ControlEditandtf-kernel-contractstopped before any summary. Chips before M5 have no decode control, so only the M5 was affected, and the GitHub checks don't run the contract on a GPU.The control now edits the new text, as the issue proposed. It's a test-only, one-line change.
Checks:
zig fmt --checkand a plainzig build(255 of 255 steps). An M5 Ultra contract run with--only "non-finite values unmasked"is queued, and its numbers go here.