Skip to content

CI: the cache tool's own test runs only when its files or Zig's version change, on main too - #2277

Merged
ashhart merged 2 commits into
mainfrom
lead/ci-restat-test-skip
Nov 5, 2026
Merged

ashhart merged 2 commits into
mainfrom
lead/ci-restat-test-skip

Conversation

@ashhart

@ashhart ashhart commented Nov 5, 2026

Copy link
Copy Markdown
Owner

A follow-up to #2274. The cache tool's own regression test now runs only when a change touches the tool, no-gpu.yml or Zig's version, on main as well as on pull requests.

#2274 already skipped it on pull requests that leave those files alone. Main still ran it on every push, adding about 2 minutes to each main zig job. For a push, main now compares with the commit before the push, as the lean check does. A push whose previous commit isn't in the checkout, such as a branch's first push, still runs the test.

Test plan

  • This PR's CI runs the test, since it changes no-gpu.yml
  • After landing: the next main push that touches none of those files logs "None of the files it covers changed." and skips it

…on change, on main too

#2274 skipped it on pull requests that leave the tool, this workflow and Zig's version
alone, but main ran it on every push, about 2 minutes of each main zig job. Main now
compares with the commit before the push, as the lean check does, and runs the test
only when one of those files changed. A push whose previous commit isn't in the
checkout, such as a new branch, still runs it.
@ashhart
ashhart force-pushed the lead/ci-restat-test-skip branch from a92c6c3 to 4bc033b Compare November 5, 2026 21:12
@ashhart
ashhart merged commit c76c302 into main Nov 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant