Repository navigation
test(hip): the planned walk's tf_sum_partials records hold ROCm 10.1's hipcc (HIP 7.16) - #2233
Merged
Merged
Conversation
Owner
|
Thanks @AbrahamCete for following up on #1961's records so quickly. Taking them from the release hipcc's own RECORD lines, and showing the 8 lines go current, is exactly the check. Ready to land, and it's in the queue. |
ashhart
added a commit
to AbrahamCete/TensorFold
that referenced
this pull request
Nov 5, 2026
ashhart
force-pushed
the
fix/hip-sum-partials-records
branch
from
November 5, 2026 08:58
0d96eac to
8d61118
Compare
ashhart
force-pushed
the
fix/hip-sum-partials-records
branch
from
November 5, 2026 10:55
8d61118 to
2f03c32
Compare
Owner
|
Thank you @AbrahamCete. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
Owner
|
Thanks @AbrahamCete! This is in TensorFold 1.2.3, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
hip_records.zighas records for the planned walk'stf_sum_partialsandtf_sum_partials_act, which came in with #1961. They held the system compiler's register counts. They now hold the counts from ROCm 10.1's hipcc (HIP 7.16.26385), the compiler the HIP records follow, taken from itship-kernel-contract-limitsRECORD lines:tf_sum_partials: 21 VGPRs and 20 SGPRs (22 on gfx1201). It held 23 VGPRs and 20 or 21 SGPRs.tf_sum_partials_act: 22 VGPRs and 22 SGPRs (24 on gfx1201). It held 24 VGPRs and 21 or 22 SGPRs.Only these 8 usage lines change. No kernel or launch changes.
atc overlap --json(2026-11-05 06:18Z, on main 249e33b): this head shareship_records.zigwith hip flashnext: WMMA sparse attention for prompt chunks (sparse=wmma) #1622, hip flashnext: sparse attention with a lane a key over several heads, the scalar kernel's bits #1877, Nemotron Parse on HIP: NVIDIA's checkpoint, token-exact against its HF example #1941, LightOnOCR-3 (0.8B, 1B, 4B) on native HIP, with the model card's oracle #1965 and Clef-Flash: joint-schema decisions on /v1/systemone (HIP) #2048. Clef-Flash: joint-schema decisions on /v1/systemone (HIP) #2048 merges clean. The other four already conflict with main in that file without this change, and none of them touches thetf_sum_partialslines, so their conflicts are inherited.Checks on this head
git archivetrees.python3 tools/zig/lean_check.py, on the base and on this head: 425 and 425, 0 new (tools/zig/lean_new.py).zig build test -Dhip=true --summary all: 575/575 steps, 7352/7414 tests passed, 62 skipped, 0 failed.zig build hip-kernel-contract-limits -Dhipcc=<ROCm 10.1>/bin/hipcc:FAIL kernel-contract-limits: 14 problems, against main's 22.record currenton gfx1030, gfx1100, gfx1151 and gfx1201.zig build hip-kernel-contracton gfx1151, built with that hipcc:SUMMARY gfx1151 93 kernels: 93 pass gates 1-4, 0 fail, 2 known findings; 11 controls: 11 red as planted, 0 missed; 4 limit problems, exit 1 for the limit problems. Main reads the same with 6 limit problems.zig build test-golden --summary all: 5/5 steps.zig fmt --checkandgit diff --check: clean.zig,zig-windows,zig-macos-dev-tools,fmt,release-paths, andbenchmark-clientson Ubuntu and Windows).Receipt
n/a. The change edits contract records only. It changes no kernel, launch or host code, so it cannot reach inference.
Checklist
hip-kernel-contract-limitsis the check, 8 stale records before and 0 after.)If it's useful, the other 14 records can follow the same way.