Skip to content

test(hip): the planned walk's tf_sum_partials records hold ROCm 10.1's hipcc (HIP 7.16) - #2233

Merged
ashhart merged 2 commits into
ashhart:mainfrom
AbrahamCete:fix/hip-sum-partials-records
Nov 5, 2026
Merged

ashhart merged 2 commits into
ashhart:mainfrom
AbrahamCete:fix/hip-sum-partials-records

Conversation

@AbrahamCete

@AbrahamCete AbrahamCete commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

hip_records.zig has records for the planned walk's tf_sum_partials and tf_sum_partials_act, which came in with #1961. They held the system compiler's register counts. They now hold the counts from ROCm 10.1's hipcc (HIP 7.16.26385), the compiler the HIP records follow, taken from its hip-kernel-contract-limits RECORD lines:

  • tf_sum_partials: 21 VGPRs and 20 SGPRs (22 on gfx1201). It held 23 VGPRs and 20 or 21 SGPRs.
  • tf_sum_partials_act: 22 VGPRs and 22 SGPRs (24 on gfx1201). It held 24 VGPRs and 21 or 22 SGPRs.

Only these 8 usage lines change. No kernel or launch changes.

Checks on this head

  • Head commit: 0d96eac, on main 249e33b. Both sides were built from git archive trees.
  • Lean checker, python3 tools/zig/lean_check.py, on the base and on this head: 425 and 425, 0 new (tools/zig/lean_new.py).
  • Tests run, with the command and pass, fail and skip counts:
    • zig build test -Dhip=true --summary all: 575/575 steps, 7352/7414 tests passed, 62 skipped, 0 failed.
    • zig build hip-kernel-contract-limits -Dhipcc=<ROCm 10.1>/bin/hipcc: FAIL kernel-contract-limits: 14 problems, against main's 22.
      • The 8 lines of these two kernels now read record current on gfx1030, gfx1100, gfx1151 and gfx1201.
      • The 14 left belong to other kernels' records: GLM-OCR's text and vision RoPE, BF16 axial vision RoPE, the MoE combine gate, the 64-row item tile and Torch BF16 RoPE. This PR leaves them alone.
    • zig build hip-kernel-contract on gfx1151, built with that hipcc: SUMMARY gfx1151 93 kernels: 93 pass gates 1-4, 0 fail, 2 known findings; 11 controls: 11 red as planted, 0 missed; 4 limit problems, exit 1 for the limit problems. Main reads the same with 6 limit problems.
    • zig build test-golden --summary all: 5/5 steps.
    • zig fmt --check and git diff --check: clean.
  • CI: green on 0d96eac, all 7 checks (zig, zig-windows, zig-macos-dev-tools, fmt, release-paths, and benchmark-clients on Ubuntu and Windows).
  • Not run, and why: the GPU contract on gfx1030, gfx1100 and gfx1201, because I have no card. The offline limits above check their records.

Receipt

n/a. The change edits contract records only. It changes no kernel, launch or host code, so it cannot reach inference.

Checklist

  • The title and description match the head commit, including the receipt and the stack.
  • New tests fail before the change, pass after it, and skip cleanly without their dependency. (n/a: no test is added; hip-kernel-contract-limits is the check, 8 stale records before and 0 after.)
  • Comments and docstrings are one line. No measurements or history in the source.
  • No personal data, machine names, internal hosts or local paths in the diff or its commits. No AI attribution lines.

If it's useful, the other 14 records can follow the same way.

@ashhart

ashhart commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Thanks @AbrahamCete for following up on #1961's records so quickly. Taking them from the release hipcc's own RECORD lines, and showing the 8 lines go current, is exactly the check. Ready to land, and it's in the queue.

ashhart added a commit to AbrahamCete/TensorFold that referenced this pull request Nov 5, 2026
@ashhart
ashhart force-pushed the fix/hip-sum-partials-records branch from 0d96eac to 8d61118 Compare November 5, 2026 08:58
@ashhart
ashhart force-pushed the fix/hip-sum-partials-records branch from 8d61118 to 2f03c32 Compare November 5, 2026 10:55
@ashhart
ashhart merged commit e30195d into ashhart:main Nov 5, 2026
0 of 7 checks passed
@ashhart

ashhart commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Thank you @AbrahamCete. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes.

@ashhart

ashhart commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Thanks @AbrahamCete! This is in TensorFold 1.2.3, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants