Repository navigation
Conversation
4 tasks done
ashhart
force-pushed
the
lead/pinned-download
branch
from
November 5, 2026 01:08
8eac6d7 to
96aafce
Compare
ashhart
force-pushed
the
lead/pinned-download
branch
from
November 5, 2026 03:55
96aafce to
6f1404c
Compare
Owner
Author
|
Closing this: it duplicates @shuuul's #2103, which was open first and is the better fix. It stages only on integrated devices, so discrete cards keep their direct copies, and it counts the bounce in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in pinned staging for
DeviceBuffer.download(#2102). WithTF_CUDA_PINNED_DOWNLOAD=1, a download copies into one reused pinned buffer per driver and context, then into the caller's slice. Copies over 64 MiB go in 64 MiB pieces. A failed copy hands its buffer to the existingcopy_sourcequarantine. With the switch unset, or any value but exactly1, the call is main's unchanged line.This doesn't claim to fix the fault. The issue has no deterministic reproducer, so the host tests prove the path, not the cure. The fake-driver tests cover the destination pointer, reuse, growth, the pieces, one buffer per context and quarantine after a failed copy.
Limits
downloadAsyncand 27 directcuMemcpyDtoH_v2calls in 20 family files don't go throughdownload, so the switch doesn't reach them.The reporter's fork saw 10 misses in 60 runs with pageable memory and 0 in 100 with a pinned bounce; a run on a GB10 with this switch would be the real check.