Repository navigation
feat(profile): register GLM's host KV switches and one name lookup for readers - #2177
Merged
Merged
Conversation
devopsfortunato
force-pushed
the
profile-glm-kv-host-1660
branch
from
November 4, 2026 22:15
a570b9b to
4826747
Compare
8 tasks done
Owner
|
Thanks @devopsfortunato. The two host-KV switches now read through the registry with main's exact- |
This was referenced Nov 5, 2026
ashhart
force-pushed
the
profile-glm-kv-host-1660
branch
from
November 5, 2026 01:07
4826747 to
7b13215
Compare
…r readers TF_GLM_KV_HOST and TF_GLM_KV_HOST_SHARED join the --profile registry as identical-class, exact-one switches scoped to GLM CUDA, with ashhart#1795's identical tokens at TP=2 as their evidence. Their readers now resolve through the registry: cuda_kv_host's flags and the GLM rank settings, whose fingerprint still carries the resolved value. Readers that look a switch up by name use the new core.profile.lookup, which serves a registered name from the table and every other name from the environment as before. stable supplies no value, so nothing is enabled or changed by default; profile_line reports the two overrides for GLM CUDA only. Part of ashhart#1660.
ashhart
force-pushed
the
profile-glm-kv-host-1660
branch
from
November 5, 2026 03:10
7b13215 to
c84b62a
Compare
Owner
|
Thank you @devopsfortunato. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
Owner
|
Thanks @devopsfortunato! This is in TensorFold 1.2.3, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
fast-exact/faststay refused until their gates exist.b85fd1f46); this adds48267472b.atc overlap --json(after the final rebase, baseb85fd1f46): no source-file conflict is added.#1423's conflicts inzig/src/families/glm/cuda_ranks.zig,cuda_ranks_test.zigandcuda_forward_pieces.zigare identical with and without this change;#2106conflicts onCHANGELOG.mdon its base alone;#2116shares only theCHANGELOG.mdtop-bullet slot, the usual slot every pull request here shares, and the two bullets both survive the merge.Before: the registry covered eight switches;
TF_GLM_KV_HOSTandTF_GLM_KV_HOST_SHAREDwere read only throughstd.c.getenv, so the table could not describe them, the startup line never named them, and a switch looked up by name had no single reader.After: GLM's host-KV tier is two
identical-class, exact-one rows scoped toglm5_nexton CUDA, carrying #1795's identical tokens at TP=2 on two GB10s as evidence. Their readers resolve through the registry:cuda_kv_host.onHost()/shared()callprofile.get, andcuda_ranks.environment(the lookupcuda_nativepasses toSettings.read) calls the newprofile.lookup, which serves a registered name from the table and every other name from the environment exactly as before.Settings.read's tests keep injecting their own lookup, so their fixtures are unchanged; the rank fingerprint still carries the resolved value, so ranks that disagree still stop before weights load.stablesupplies no value for either row, so unset, set and malformed environments resolve to the same value they do on main, and the startup line reports the two overrides for GLM CUDA only.TF_GLM_KV_HOST_GIBstays outside the registry: it sizes the pages rather than choosing a policy.Checks on this head
48267472bonb85fd1f46.python3 tools/zig/lean_check.py, on the base and on this head: base 425, head 425, 0 new findings..zig-version, aarch64 Linux, no GPU:zig build test-profile: 8/8 pass.zig build test-server-cpu: the step's test binary, run directly with its seed, passes 960/960 and exits 0. Thezig buildwrapper on this 4-core shared host intermittently reportsrun test failurefor it with no failing test named; a re-run or the same binary run directly passes, and the step never names a test.zig build test-glm-prompt-settings-host test-glm-startup-host test-glm-pages-host: 30/30 pass.zig build test --test-timeout 10m: the full host unit suite.zig fmt --check build.zig zig: clean.fmt,benchmark-clients(both OSes),release-pathsandzig-macos-dev-toolshave passed, and the remaining jobs are what this description waits on.Receipt
b85fd1f46, head48267472b, Zig 0.17.0 (zig-aarch64-linux), no backend toolchain, aarch64 Linux host, no GPU, no checkpoint.Checklist