Repository navigation
Conversation
The start-up line naming the free pages on the per-CPU lists printed only when 0.25 GiB or more happened to sit there, so start-up output changed with the box's memory state (ashhart#2127). The pool still counts them; only the line moves to debug.
Owner
|
Thanks @jschmied, moving |
Contributor
Author
Owner
|
/atc exchange 6916ec3e24717319daf9f25baf65c4980e278a4df5f5285ca31e13bceb1d32ac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2127. The extra Nemotron start-up line there is main's
noteParked: it logs at info level whenever 0.25 GiB or more happens to sit on the kernel's per-CPU page lists at start-up. So the line shows up or not depending on the box's memory state (in the rerun table, #2127 (comment), main read 0.45 to 0.53 GiB, and the first run had read below 0.25).This moves the line to debug level. The budget still counts the parked pages, as #1323 intended; only the log level changes. Both callers (
cuda.zig, the CUDA budget and the rank room) are unchanged.zig build testand the no-GPU CI steps (kernel contract, golden, server and pull security, fuzz) pass. Lean adds 0 problems against main.