Repository navigation
native tests: the Qwen27 lanes' facts read a dense model's config (test-native crash) - #2122
Merged
Merged
Conversation
Owner
|
Thanks @BobClawblaw. Pointing the runner at a dense config fixes the crash, and checking |
4 tasks done
ashhart
added a commit
to BobClawblaw/TensorFold
that referenced
this pull request
Nov 4, 2026
ashhart
force-pushed
the
qwen27-facts-test
branch
from
November 4, 2026 22:20
a103069 to
7710b04
Compare
…d plain_guard follows routed experts
ashhart
force-pushed
the
qwen27-facts-test
branch
from
November 4, 2026 23:58
7710b04 to
7bf977b
Compare
Owner
|
Thank you @BobClawblaw. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
Owner
|
Thanks @BobClawblaw! This is in TensorFold 1.2.3, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Three tests in
zig/src/native/draft_sources_metal_test.zigcall the Metal Qwen27 lanes'facts()with the runner leftundefined. Since #1125,facts()readsrunner.model.config.moe(), so the first of them crashedzig build test-nativewith SIGSEGV on main. Each test now points the runner at a model with a dense config (experts = 0). The first also checks thatplain_guardis off for that config and on once the config has routed experts. Only the tests change; the engine does not.b331731e6)atc overlap --json: one open pull request touches the same file, lfm2: DSpark drafting with owned context and confidence scheduling #1394 (LFM2 DSpark drafting), and merges cleanly with this one. Coverage was incomplete (pullFilesLimit), so I also checked the file lists of all open pull requests by hand: lfm2: DSpark drafting with owned context and confidence scheduling #1394 is the only one touchingzig/src/native/draft_sources_metal_test.zig.Checks on this head
a103069aczig build test-native: passes on M5 Ultra, macOS, Zig 0.17.0. On mainb331731e6it crashes in this test with SIGSEGV. Withfacts()mutated to ignore the config (routed = false), the test fails on theplain_guardcheck.zig fmt --check, lean (lean_new.py): pass; lean is 425 on the base and 425 on this head, 0 newzig build test, golden, the contract); the change is one test file that onlytest-nativebuilds, and CI runs the rest.Receipt
n/a: tests only, no served path changes.
Checklist
plain_guardcheck fails iffacts()stops reading the config.)