Repository navigation
docs: TF_GLM_OVERLAP_PIECES=8 beside TF_GLM_CHUNK_SOLO at TP=3 on TF_GLM_ROCE_MULTI - #2067
Merged
Merged
Conversation
Owner
|
Thanks @Bizuayeu, these two sentences make the recipe's solo paragraph actionable: 8 pieces recovers most of solo's gain on the wire, and they don't move anything without solo. The setting's default and range match the code. This can land as it is. |
ashhart
force-pushed
the
pr/docs-pieces8
branch
from
November 4, 2026 04:26
b4cc532 to
8ce6a54
Compare
Owner
|
Thank you @Bizuayeu. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two sentences at the end of the paragraph #1996 added to the GLM recipe's "Prompt chunk size": what
TF_GLM_OVERLAP_PIECESdoes, and that in #1994's run 4 solo on the wire came 1.7–3.6% sooner at the default 3 pieces and 6.1–7.8% sooner at 8, against the wire without solo, while in run 5 8 pieces without solo stayed within 1% of 3. Documentation only.0d43416f9, which has docs: TF_GLM_CHUNK_SOLO gains a little under half at TP=3 on TF_GLM_ROCE_MULTI #1996's paragraph.atc overlap --json: it didn't complete (pullFilesLimit,pullFilesUnavailable,timeLimit), so I checked the file by hand: of the 171 open pull requests, only glm cuda: a prompt step takes two chunks while no other stream decodes, each one's exchanges under the other's sites #1423 touches it. glm cuda: a prompt step takes two chunks while no other stream decodes, each one's exchanges under the other's sites #1423 changes the same section about 30 lines above, in another sentence, and the recipe merges without a conflict.Checks on this head
b4cc532d6python3 tools/zig/lean_check.py, on the base and on this head: 424 and 424, no new findings.zig build test499/499 steps (6,598 of 6,646 tests, 48 skipped). No failures.b11a8b0a0, five of the seven checks pass (zig,fmt,release-pathsand bothbenchmark-clients).zig-windowshit the job's 60-minute limit insidezig build test, after 35 minutes without output; main's own run atb11a8b0a0passed it in 23 minutes.zig-macos-dev-toolsnever started: no hosted macOS runner picked it up (GitHub notes capacity constraints on macOS arm64).Receipt
n/a: documentation only. The numbers are #1994's runs 4 and 5 (#1994 (comment)): three GB10s at TP=3,
Bizuayeu/GLM-5.3-Flash-XSFP4at88736f91with its MTP drafts,--parallel 8,TF_GLM_KV_SHARE=32,TENSORFOLD_PREFILL_SHARE=0.7,TF_GLM_ROCE_MULTI=1, two fresh servers an arm, each cold prompt's first token fromtools/bench_cache.py --require-cold, and one token hash for each prompt length across all fourteen servers. The binary isv1.2.1with one line out that acts only underTF_GLM_PROF=1, which both runs leave unset, so its bits arev1.2.1's. #1996's paragraph above stays run 1's (main9e8c368b0).Checklist