Repository navigation
contract: qwen27 attention_io at the other two shapes Geometry admits, GQA16's 32 over 2 and the 9B's 16 over 4 - #2063
Merged
ashhart merged 2 commits intoNov 4, 2026
Conversation
Owner
|
Thanks @cshintov, this is the follow-up we asked for on #2013, and the check with the old |
…, GQA16's 32 over 2 and the 9B's 16 over 4
ashhart
force-pushed
the
bugfix/qwen27-keep-contract-shapes
branch
from
November 4, 2026 00:59
6b7ae97 to
c29658a
Compare
Owner
|
Thank you @cshintov. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The review on #2013 asked for keep at the other two shapes
Geometry.checkadmits. The qwen27 attention_io contract now runs pack, append, host keep and device keep at all four: the 27B (24 over 4), its two-Mac rank (12 over 2), GQA16 on one Mac (32 over 2) and the 9B (16 over 4). Test only; no kernel or engine change.atc overlap --json: atc is not installed here; no open pull request toucheszig/tests/contract/metal_q27_attn.zig.Commit:
contract: qwen27 attention_io at the other two shapes Geometry admits, GQA16's 32 over 2 and the 9B's 16 over 4Checks on this head
python3 tools/zig/lean_check.py: 424 problems on the base, 424 on this head, 0 new.zig build test-qwen27,test-qwen27-keep-host,test-qwen27-plans-hostandtest-kernel-contractpass;zig fmt --check build.zig zigpasses.Receipt
Kernel contract, only when a GPU kernel is new or changed
No kernel changes; the existing qwen27 attention_io kernels gain two registered shapes each.
tf-kernel-contract --only qwen27on this head:SUMMARY 16 kernels: 16 pass gates 1-4, 0 fail, 0 known findings; 2 controls: 2 red as planted, 0 missed; 0 limit problems.attention_io.metalput back, the GQA16 keep and device keep fail ("staging keys row 1 head 0 is not stream 0's row 66" at 3x32x64) and the 9B's pass, as they should at 4 KV heads.Checklist