Repository navigation
fix(profile): report Nemotron CUDA paging overrides - #2061
Conversation
|
Thanks @garvrao80, this is a tidy fix. A Nemotron server started with Two small things:
Happy to land it with those. |
|
Addressed both points in
The Unreleased changelog entry calls out the two scoped Full Linux and Windows host/kernel-contract/golden/fuzz checks pass, as do both platforms' focused/process checks. Lean adds zero findings over current main. Both plain builds pass too (Linux 31/31 steps, Windows 27/27), and all seven GitHub CI checks pass on this head. |
|
Thanks @garvrao80. |
0c3a074 to
f691457
Compare
|
Thank you @garvrao80. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
|
Thanks @garvrao80! This is in TensorFold 1.2.3, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.3 |
What this changes
A Nemotron CUDA server started with
TF_KV_PAGES=0currently printsregistered overrides: none. Report that override, and exactall, for bothnemotron_handnemotron_h_omni. Keep its default-on parser:off,auto, empty text and every other spelling still select on and do not appear as overrides. GLM's same-named automatic policy retains its existing reporting.Keep one environment lookup and disjoint family/backend policy rows. The registry still names eight variables;
TF_KV_PAGESnow has separate GLM and Nemotron rows.report_valuesexplicitly describes exact-value overrides in capabilities metadata. Compile-time checks reject overlapping scopes and missing variables. The native Nemotron adapter uses the shared environment-first lookup while preserving its parser semantics, allocation and admission rules.00e7dddbdb2dd0c481f3d7e8d850fa3e1f2e80b7, updated through2a7c7b7e7in the review follow-up.Review follow-up
Head
0c3a0741c, including current main at2a7c7b7e7:pagingOf(raw). A deterministic test compares all 16 unset/exact/fallback inputs with the original expression on every run. Four planted errors (unset default,0,all, fallback) each fail the intended assertion. Keep the live-reader integration check too.TF_KV_PAGEScapability rows and optionalreport_valuesmetadata.Checks on the original head
4c3cba3e7c84dbcb4db0b68630dc740ef647bc0c; Zig 0.17.0, Windows x86_64 and Linux x86_64 (WSL).TF_KV_PAGES=0versusnoneassertion; it passes with the fix. Profile and startup tests cover both Nemotron aliases, GLM's automatic policy, exact/fallback values, backend isolation and bounded output.c4eb274cd5614c2407abe09de21792fc584d9b95passes all eight profile tests and four startup-formatting tests on Linux.zig build test test-kernel-contract test-golden fuzz-cortheon -j4 --test-timeout 10m --summary allpasses 529/529 steps, 5,197/5,215 reported tests passing and 18 skipped (with cached work reused). The first Windows sweep passes 490/490 steps, 6,003/6,121 reported tests passing and 118 skipped; fresh Windows CI also passes on this published head. The final committed-tree Windows recheck passes 490/490 steps, with 1,033/1,044 reported tests passing and 11 skipped (cached work reused). Plain builds pass 31/31 steps on Linux and 27/27 on Windows.git diff --checkpass.server-cpuaggregate has an existingfake_servecompile error (slide_model.zigcannot importcore), reproduced on the untouched base. Its CLI component builds independently; no fake-server fix is included here.Receipt
Native paging retains its original default and exact
0/allparser. The shared lookup returns the original environment value without coercion; the Windows wrapper's only special case is unrelatedHOME. This changes configuration reporting, not paging arithmetic or kernels. No live GPU/checkpoint, token-equivalence, throughput or memory qualification is claimed; no CUDA device or Mac is attached. Those are not replaced by the host checks above.Checklist