Repository navigation
feat(profile): register GLM paging and report resolved selection - #1959
Merged
Merged
Conversation
Owner
|
Thanks @garvrao80. We reviewed this independently: GLM's paging choice is unchanged. The variable is read at the same call site, per load, on every rank before rank agreement, and |
ashhart
force-pushed
the
feat/glm-paging-profile
branch
from
November 3, 2026 03:22
2671fad to
52bb7e0
Compare
Owner
|
Thank you @garvrao80. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
Owner
|
Landed as 099ca83. Thanks @garvrao80! |
Owner
|
Thanks @garvrao80! This is in TensorFold 1.2.2, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
GLM CUDA's
TF_KV_PAGESnow appears in the stable profile registry, and each rank reports the resolved paging selection before engine construction. Today, leaving the variable unset selects pages at TP >= 2 with BF16, but windows on one rank or with FP8; the profile summary cannot explain this because the setting is unregistered.Example with the variable absent, BF16 and two ranks:
onand theFp8OnPageserror for explicit pages with FP8.autosyntax distinguishes automatic policy from an explicit policy, includingoff/0. A forced policy can match the automatic storage at a particular rank count; the family report shows the actual resolved boolean, rank/world and precision. It does not guess placement from environment variables.fast-exact/fastremain unavailable.Refs #1660; follows merged #1944. This covers one additional switch, not the rest of the RFC. Existing BF16 paging evidence is #1322.
Receipt
089a18dff; Zig 0.17.0, Windows x64 and native WSL Ubuntu x64. No GPU or checkpoint required for these configuration/reporting tests.zig build test-profile test-glm-startup-host: 13/13 tests pass on Linux; Windows focused targets pass (the registry also passes all six tests directly). The independent expected-case table checks 13 inputs, every rank count 1..16 and BF16/FP8, with leader/follower startup calls: 806 invocations. Tests retain peer notification and constructor error coverage and verify that reports precede construction and follow liveness.zig build test test-kernel-contract test-golden test-server-security test-pull-security fuzz-cortheon -j4 --test-timeout 10m --summary all: exit 0, 521/521 steps; 6,557/6,602 tests passed, 45 skipped, zero failures. Server goldens 55/55 equal; server-security 24/24. Windowszig build test test-kernel-contract test-golden fuzz-cortheon -j4 --test-timeout 10m --summary all: exit 0, 473/473 steps; 5,091/5,186 tests passed, 95 skipped, zero failures. Goldens 55/55 equal on each platform. These are the build summaries; cached steps were reused.zig build -j4 --summary all: exit 0, 31/31 steps. Windows plain production build: exit 0, 27/27 steps succeeded.zig fmt --check,git diff --check: pass. Lean: 439 findings on base and candidate, zero new.yours; anonymous public session. ATC file coverage was incomplete, so all 156 open PR file lists were checked separately. Three overlap these files. Merge-tree comparisons against the same main base show no new conflict blocks; older glm cuda: TF_GLM_KV_HOST keeps the KV pages' latent rows in pinned host memory #1795 and GLM-5.3-Flash on CUDA keeps conversation states on disk, every rank's part (--learn-conversations) #1411 already conflict with main, CUDA: Qwen4 and tensor-parallel loaders drop the checkpoint's pages after every rank is ready #1887 merges cleanly. The overlapping GLM recipe edit was omitted to keep this change narrow.Checklist