Repository navigation
app: control vector picker and strength in Engine advanced - #1951
Open
BlivionIaG wants to merge 3 commits into
Open
BlivionIaG wants to merge 3 commits into
BlivionIaG wants to merge 3 commits into
Conversation
A settings panel beside the engine's other advanced options, the picker's path taken through the OS picker and never as a renderer argument, the engine's --glp/--glp-alpha arguments, and the audit recording the vector's state and strength rather than its path. The panel is inert when the engine does not advertise --glp. Split out of ashhart#1835, whose engine change carries the mechanism.
The app branch's base predates main's 5fe74eb; without it the zig checks fail on the server's test target before the app checks run.
Contributor
Author
|
CI is green on The first run's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the desktop app's part of #1835 into its own PR, as the review asked, so app changes go through the app's review.
What this is
Settings → AI & Models → Engine advanced gains a control-vector picker and a strength field. The picker returns a path through the OS picker only, never as a renderer argument; the audit records the vector's state and strength, never its path. The engine gets
--glp FILEand--glp-alpha ALPHAfrom the panel, and the panel stays inert when the engine does not advertise--glp. The packaged app keeps its sha256-pinned engine.The 32 files are the app's alone: the settings panel, IPC and preload, the shared types and schema, the mock engine, and the 13 locale packs.
Dependency
The flags this panel sets are carried by the engine change in #1835 (
feature/glp-steering). This PR contains no engine or Zig change; merged alone it leaves the panel inert on engines without--glp.Verification
Not run in this environment: the app suite needs its own dependency install. The patch applies cleanly to main at 16d95cc with no engine change.
Split out of #1835.