Repository navigation
qwen4 host test: run #1739's merge body (main's zig CI) - #1935
Merged
Merged
Conversation
#1739 moved fn_attn_merge's loop into fn_attn_merge_body, which the kernel calls; the Qwen4 CUDA attention host instrument extracted only the kernel, so test-qwen4-host, test-qwen4-gdn-host and test-qwen4-projection-bodies stopped compiling. Extract the body too, as inline host code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's zig CI has been red since #1739 landed (9bb51cd).
#1739 moved
fn_attn_merge's loop intofn_attn_merge_body. The Qwen4 CUDA attention host instrument extracted only the kernel, so the generatedqwen4_cuda_attention_host.cppfailed withuse of undeclared identifier 'fn_attn_merge_body'. That broke test-qwen4-host, test-qwen4-gdn-host and test-qwen4-projection-bodies.This change also extracts the body, as inline host code, ahead of the kernel.
Checked locally: all three steps pass, there are no new lean problems, and fmt is clean.