Repository navigation
glm cuda: TF_GLM_CHUNK_SOLO=4096 beside --drafter is refused by name - #1842
Merged
Merged
Conversation
A drafter's steps take one chunk, so the wider buffers would hold 1.6 to 1.9 GiB that no pass uses. Refused before the weights load, as TF_GLM_KV_SHARE without pages is, on every rank; with that, the step's own checks no longer need the drafter.
ashhart
force-pushed
the
pr/glm-solo-drafter
branch
from
November 2, 2026 04:57
0f67c9d to
16a756c
Compare
Owner
|
Thank you @Bizuayeu. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refusal you suggested on #1823 (comment):
TF_GLM_CHUNK_SOLO=4096beside--drafterholds 1.6 to 1.9 GiB of prompt buffers that no pass uses. It was the last commit on that branch (a27444ebb) and the head that merged doesn't have it, so here it is on its own. A server without both settings starts and runs as it does on main.What this changes
prompt_solo.refuseruns before the weights load, on every rank, asTF_GLM_KV_SHAREwithout pages does, witherror.GlmSoloWithDrafterand its line inexplain.prompt_solo.atandallowedlosee.drafter != null, which nothing reaches now.## Prompt chunk sizesays so.Receipts
0f67c9da9):test-cuda-host276/276 steps (4,236 of 4,246 tests, 10 skipped),zig build test456/456 steps (1,894 of 1,913 tests, 19 skipped),test-kv-pool33/33,compile-cuda-tests10/10 (the CUDA runner, which CI does not build, also for aarch64),compile-config-server7/7,zig fmt --check, andtools/zig/lean_check.py(424 against main's 424, 0 new).Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. (No step changes.)SUMMARYline is in the receipt. (No kernel changes.)refuse, which main does not have.)