Repository navigation
deepseek: admit supported dsq-1 checkpoint metadata - #1641
Merged
Merged
Conversation
Owner
|
Thanks, this looks good. Keeping the dsq-1 check to the format identifier plus the codebook and output-scale policy, and leaving the trellis, scale and marker checks with the loader, is the right split, and the refusal and legacy tests cover it well. It builds on #1640 (its admission test uses |
The public EXL3 pack published by jayleaton uses dsq-1 metadata with a producer annotation. Preserve DeepSeek's public configuration and jayleaton's pack metadata as a regression fixture. Admit the supported format independently of producer name while retaining geometry, tensor-layout, scale and marker checks. Host admission and malformed-storage tests do not qualify the real checkpoint or GPU execution. (cherry picked from commit 98f2a38)
ashhart
force-pushed
the
dsv41-up/dsq-admission
branch
from
October 30, 2026 16:26
69537d1 to
e250820
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The public Flash-1017 EXL3 pack declares
quantization_configas dsq-1 metadata with a producer annotation, so main refuses it asUnsupportedCheckpointbefore reading any tensor. This admits the supported format independently of the producer name. Geometry, tensor-layout, scale and marker checks stay as they are.Regression fixtures: DeepSeek's public 1017 configuration, and the pack's published metadata. Host admission tests cover the real
Config.readmetadata path. Malformed-storage tests check the native refusals.Issue: none open upstream. Stacked on: #1640 (asset generators), whose
Config.parseMetadatathe admission test uses. Review onlyddde40de8812..69537d14db7c.Receipt
69537d14db7con main3f0a715c4; Zig 0.17.0; host checks on a Linux aarch64 DGX Spark (GB10, CUDA 13.0). Real-pack boot on two GB10s, TP=2 over RoCE, checkpointjayleaton/DeepSeek-V4.1-Flash-1017-EXL3-2.8bpwrevision859396591c34,TF_EXPERIMENTAL=deepseek.83ba53298924: passed. Both ranks reached readiness; the recipe smoke, the canary and a strict tool call passed;MissingTritonVariant0 in both rank logs; 2048 greedy tokens in 51.1 s withtoken_sha2567538b20557b1…, the same as the downstream build of this series.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. (Not measured for this change alone.)SUMMARYline is in the receipt. (No kernel changes.)test-dsv41-shared.)