Repository navigation
Conversation
The seam carries one round's partials between two Macs: pair.metal writes a frame, the host relay owns the exchange instead of spinning on device counters (which only works while both ranks share a launch group), and pair_sum completes the partial on the far rank. The payload is f32, the seam's accumulation, and simd_qmm grows the matching store. pair.zig splits into pair_layout and pair_loopback so each module stays under the 600-line rule. Nothing registered the seam before: three of the four kernels already ran under the older ABI on the shipped glm_dsa speed-up path, but there was no record and no spec, so no gate covered the kernels this stack changes. Add the four launch records, the seam spec with its four probes, the `metal pair ` route in the limits table, and the fp32-out simd_qmm variant, so the transport and family changes that follow have a SUMMARY to post. The glm_dsa call sites and the two Pipeline.load test call sites are forced by the shared signatures; the family changes themselves come later.
On a pair rank the embedding table is global while the vocabulary in the split config is the shard's width, so the gather bound took the shard's number and read the wrong rows; embedBound now takes the whole table and refuses a bound below it. Rank-sliced projections, the head seam, the GDN partials and the attention plan follow the same split, and the drafts-off path keeps the two ranks in lockstep. The regression test pins the old behaviour (124160) against the new (248320) and fails when the split width is used again.
A supervised pair has to survive an unattended night: rank 0 now waits for rank 1's handshake before it advertises /health, the first turn is warmed so the client does not pay the load, and either rank exiting takes the other down instead of leaving it serving alone. The launch script starts and stops both, with the kill/restart drill recorded in the receipt. The benchmark and TF_DUMP_IDS receipts in server/ are the support code for those runs; dump.zig and input.zig are their two halves.
tf-qwen27-tp-check runs rank-1 parity bit for bit and then joins two rank-local shards through pair.Loopback on one Mac, comparing ids against the single-host load and the forced replay. It SKIPs without a checkpoint, so the suite stays clean on hosts that have none. The module registration is the only build change.
pair_accept.py walks a live pair through the fixture set and compares each token_sha against the recorded single-host oracle, so the check needs no second reference machine. pair_supervise.sh starts rank 1 on the peer, waits for the handshake, starts rank 0, polls both health endpoints, restarts either rank if it dies, and stops both on SIGTERM. Hosts and paths come from arguments or environment only.
Add the recipe for a supervised 27B pair and carry the runbook delta the lifecycle needs. known-issues records the embedding gather defect (the split vocabulary used as the gather bound) and what the fix leaves behind: the code-128, code-256 and chat-128 fixtures now match the single host bit for bit, and the two differences still seen are bf16 reduction-order ties, recorded with their receipts rather than called parity. No code.
akol1
force-pushed
the
qwen27/pair-docs
branch
from
October 27, 2026 03:58
e6e6e96 to
cb488f2
Compare
akol1
marked this pull request as ready for review
October 27, 2026 04:32
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Documents the two-Mac 27B path where a reader will look for it.
docs/recipes/qwen3.8-27b.mdgains a "Two Macs over Thunderbolt" subsection: rank 1 first, then rank 0, the settings files, the--parallel 1requirement, the per-rank split widths, and every flag the pair refuses.docs/known-issues.mdrecords the bf16 reduction-order tie at the seam and the pair's refusals as known limits, naming the two fixtures that hit the tie.RUNBOOK.mdgains the pair's two-line delta. No code, test or gate behaviour changes.Refs #1236 and #808 — the record says what this stack does, and in the same section what #808 asked for that it does not do. Stacked on #1432, #1433, #1434, #1435, #1436; the diff against
maincarries them too, so review this pull request's own commit,cb488f24.Receipt
Mac16,11), Metal only (applegpu_g16, no tensor units), checkpointTensorFold/Qwen3.8-27B-MLX-4bitat revision22d8d538154e0e5b6f8dcb1fcc74a60a0798104c, 4-bit affine with group 64. The recipe's commands are the ones those runs used.tools/bench_concurrent.py --alone --serialortoken_shaagainst"draft": false: n/a for a documentation change. The record cites both sides: the single Mac reproduces all four oracle shas, and the pair matches three and recordschat-256at58daf9743077because of the tie, so a reader is not left to discover that from a test log.tools/bench_openai.py: n/a — no code changed. The recipe points at the harness rather than quoting timings, and the receipt it refers to has one Mac at 12.3 to 13.6 tok/s on these fixtures and the pair at 16.8 to 17.1; the recipe says plainly that two Macs buy capacity for a model that does not fit one, not two times the speed on a model that does.zig build test test-goldenat this tree: 7116 passed, 45 skipped, 0 failed of 7161, with 535 of 535 build steps; the 45 skips are the image-codec and pixel cases that need libjpeg-turbo 3.1.4.1 or libwebp 1.6.0, plusSKIP qwen27-tp-check: no --model DIR. This commit adds no test and the commands it prints were run by hand on the two Macs.Checklist
"draft": false, a resumed prompt equals a fresh one, and concurrent equals solo. — documentation only; the record states which of these the pair refuses by name instead of claiming them.SUMMARYline is in the receipt. — this commit changes no kernel and quotes no newSUMMARY; the pair's filteredSUMMARYstays in the first pull request.