Repository navigation
Conversation
…Windows hosts Main's zig-windows job fails in these two files for every pull request based on it: - digest_key's portable fallback reads Windows' signed 64-bit inode as u64; Linux and macOS return from their own statx / fstat branches above it. - speech.zig sets TCP_NODELAY through sys.posix on Windows, where the socket is a Winsock handle; POSIX keeps its std.c.setsockopt. The send stall uses sys.posix, which is std.posix off Windows. Carried unchanged from ashhart#1034's two files.
Owner
|
Both fixes in this two-file split are included in 1.1.2 (https://github.com/ashhart/TensorFold/releases/tag/v1.1.2) through the Windows host work from #1034 and its digest-key follow-up, so we are closing this as superseded. Thank you. The two files' changes landed in 61270ca and 476e16d. - Synthema, Ash's AI Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
zig-windowsfails on current main (d1018b31) for every pull request based on it, in two of main's files. This PR carries only those two files from #1034, unchanged.It follows @akol1's proposed two-file split (#1034 (comment)), which also shows #1118 failing on the same lines. #1034's other 19 files remain there for the maintainers.
core/digest_key.zig:34:inodeisi64on Windows, but the field isu128u64server/speech.zig:279: the socket handle isisizeon Windows, sostd.c.setsockoptrejects itTCP_NODELAYthroughsys.posix; the send stall usessys.posixNo POSIX behaviour change:
digest_key.zig:34is reached only off Linux and macOS, which return from theirstatx/fstatbranches above it.speech.zig:280keeps POSIX'sstd.c.setsockoptcall in itselsebranch.speech.zig:3, 283-284usesys.posix, which isstd.posixoff Windows.Receipt
windows-latestzig-windows,ubuntu-latestzig), Zig 0.17.0, based1018b31.d1018b31,zig-windowsfails atdigest_key.zig:34:42andspeech.zig:279:27(for example test(deepseek): check CED replay against a linear window oracle #1118, job 118713181765).zig-windowsstill fails. It goes from 22 failed build steps to 18. With digest_key and speech compiling, the same steps reach further and exposedigest_cache_probe.zigand twocheckpoint_identity_testfailures, which Windows: main's host tests build again on Windows hosts #1034 also fixes.fabric/tp/{bootstrap,sock,fate}.zig,native/*trainer*_test.zig,server/slide_*stream_test.zigandqwen35_cost_*.zig.d1018b31. Clearing it needs Windows: main's host tests build again on Windows hosts #1034's other files plus fixes for the newer ones. This stays a draft until the maintainers choose the route.Checklist