build: fix STC symbols leaking into libasdf's exported dynamic symbols - #247
Merged
Conversation
Found this while working on libasdf-gwcs actually, which also vendors its *own* copy of STC, with some confusing results. Might actually be useful if it *could* just share libasdf's internal STC but for now I think this is a cleaner approach. Includes a new regression test that ensures against future symbol leakage outside the asdf_ prefixed symbols.
No need to use sed to drop underscores though--it *should* be possible to ignore just in the pattern passed to grep....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while working on libasdf-gwcs actually, which also vendors its own copy of STC, with some confusing results. Might actually be useful if it could just share libasdf's internal STC but for now I think this is a cleaner approach.
Includes a new regression test that ensures against future symbol leakage outside the asdf_ prefixed symbols.