Skip to content

Add warning when validation error occurs with default validate_on_read - #2126

Merged
sydduckworth merged 16 commits into
asdf-format:mainfrom
sydduckworth:warn-on-validate-on-read
Sep 2, 2026
Merged

Add warning when validation error occurs with default validate_on_read#2126
sydduckworth merged 16 commits into
asdf-format:mainfrom
sydduckworth:warn-on-validate-on-read

Conversation

@sydduckworth

@sydduckworth sydduckworth commented Aug 28, 2026

Copy link
Copy Markdown
Member

Description

Depends on #2125
Part of #2128

  • Updated file loading logic so that if a validation error occurs and validate_on_read hasn't been manually set then AsdfFutureWarning is emitted before an exception is raised.

AI Disclosure

No AI tools used

Tasks

  • run prek on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@sydduckworth
sydduckworth marked this pull request as ready for review September 1, 2026 20:53
@sydduckworth
sydduckworth requested a review from a team as a code owner September 1, 2026 20:53

@braingram braingram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates. The helpers.config looks useful.

@sydduckworth
sydduckworth merged commit 3baca15 into asdf-format:main Sep 2, 2026
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants