GH-1053: force target files to be writable when embedSourcesInClassOutputs is true - #1054
Conversation
ascopes
left a comment
There was a problem hiding this comment.
Thanks for raising a fix!
One small comment, hope that is okay!
I did wonder whether it is possible to make an integration test case for this as well by copying one of the existing ones and removing the write flags on Git. It might not be simple to do that for Windows though so not too worried if not.
f5f2b7c to
6984fdf
Compare
…ClassOutputs is true
6984fdf to
8ad0a71
Compare
|
@ascopes I remove the writable check and added an integration test that should work both on unix (linux, macos) and dos (windows). |
|
Thanks for updating, looks good to me. Once the pipeline is green, I'll merge it and tag it so it is on Maven Central for you 👍 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 94.51% 94.37% -0.14%
==========================================
Files 78 78
Lines 2056 2075 +19
Branches 132 134 +2
==========================================
+ Hits 1943 1958 +15
- Misses 79 83 +4
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes GH-1053.