Skip to content

C-API: Reproduce crg_mods modifier behaviour regarding offsets #130

Description

@CarawaySeed42

Issue Description:
The Matlab OpenCRG API function crg_mods applies mods that target a CRG's x, y and z coordinates and heading angles p.
The modifiers modify the local position and heading of the CRG road but apply the negated modification to the global coordinate offsets xoff, yoff, zoff and angle offset poff.
By doing this the local coordinates are modified but the global position stays the same.
This behaviour is not reproduced by the C-API and global positioning and orientation information is lost.

See comment by @jorauh about the behaviour and see comment by me where a modifier less approach for eas of use is proposed to do a similar modification.

Proposed Solution:
Since OpenCRG 2.0.1, the offset values of channels are now read and stored. This enables the reproduction of this behaviour.

Benefit:
Applying translation or rotation modifier would not destroy global positioning information anymore.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    isState:ReadyforCCBreviewCCB will review it and change the status to ReadyForMerge if everything is okisType:FeatureImprovementAn issue that amends or improves existing features.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions