fix : added missing API call to deleteTask and replaced console.log/alert with console.error in useTasks - #2071
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : added missing API call to deleteTask and replaced console.log/alert with console.error in useTasks#2071tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
…lert with console.error in useTasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Added the missing
api.delete(\/tasks/${id}`)call to thedeleteTaskfunction infrontend/src/hooks/useTasks.js`. Previously, the function only updated the UI optimistically but never actually deleted the task from the database.Replaced all
console.logcalls used for error logging withconsole.errorin thegetTasks,addTask, andupdateTaskerror handlers.Replaced the
alert()popup inaddTaskwithconsole.error()since the error is already thrown and can be handled by the calling component.Changes Made
frontend/src/hooks/useTasks.js: Addedapi.delete()call indeleteTask, replacedconsole.logwithconsole.error, replacedalert()withconsole.error().Impact it Made
Closes #2066
Closes #2069
Closes #2070
Note: Please assign this PR to the
tmdeveloper007account.