Added option to directly open downloaded files in the associated application (without saving them permanently) - #141
Open
mityax wants to merge 3 commits into
Open
Added option to directly open downloaded files in the associated application (without saving them permanently)#141mityax wants to merge 3 commits into
mityax wants to merge 3 commits into
Conversation
… either open or save permanently to downloads folder
Owner
|
I will check your PR next few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I created a Gtk bottom info bar that pops up when a file has been downloaded. It enables users to either open the file directly (it is saved to a tempfile then) or to save it to their downloads folder.
As I had no experience with vala before, I suggest someone experienced does a little clean up and refactoring or even rewrites the whole thing (it's not that much). Also, two things should probably get fixed so the feature works in all environments (I don't know how to do that in vala):
~/Downloads, if it doesn't exist, it's created when a file is downloaded. I'm pretty sure there is a better way to get the default download location (line 278)openbutton in the notification that appears after clickingsavein the bottom bar doesn't yet work (line 289ff)I'd really appreciate this feature to be in upstream as it helps avoiding clutter in the download folder and enables faster workflow when one just wants to view a file and not save it :)