Repository navigation
fix(android): keep live sync working in the native app - #296
Merged
Merged
Conversation
EventSource cannot send an Authorization header, and the native app's Clerk cookie never reaches the API, so the sync stream returned 401 and the app only caught up on refetch. Clerk sessions now trade their token for the same one-time sync ticket local sessions use, and the Clerk middleware verifies the redeemed token with Clerk.
Clerk's authenticateRequest asserts the publishable key, and the decorated client only gets it from process.env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live sync never worked in the Android app.
/api/sync/eventsreturned 401 on every connect, so changes made on another device only showed up after a refetch.EventSourcecannot send anAuthorizationheader. On the web, Clerk's cookie authenticates the stream. The native app runs atapp.macrotrackr.com, so that cookie never reachesmacrotrackr.com.What changes
/api/sync/events, the Clerk middleware redeems the ticket and verifies the token inside it with Clerk, using the same authorized parties as every other request.On the web the cookie still authenticates the stream first, so the ticket goes unused there and expires.
Testing