ci: Set bencher measure slug as source of truth#482
Merged
Conversation
The PR comment showed n/a for main-side prove-time, peak-rss,
execute-time, and fft-cost: fetch-main keyed metrics by the measure's
display NAME, and those four measures predate this pipeline with
renamed display names ("Prove Time") — uploads attach to them by slug,
so the name never matched our row keys.
fetch-main now reads the slug only, and every row key is born
slug-shaped so that identity holds end to end: mergeSpans emits
phase-<slugified span> (phase-stark-prove) instead of phase:<span>,
matching the slugs bencher already derived for the existing phase
measures — history stays continuous and no console edits are needed.
The registry metric lists were already slugs. Display names remain
free to rename in the console; slugs must stay equal to the row
vocabulary.
Verified against live bencher data at main's tip: all measures of an
aiur-check-prove report come back under their row keys.
samuelburnham
enabled auto-merge (squash)
July 10, 2026 14:33
A single failed cell (e.g. zisk's persistent bitblast abort) stamped the whole report '❌ benchmark run failed' and appended a second Workflow-logs link (the report footer already has one). With a report present, prepend one soft partial-results note instead; the ❌ heading, parse-error quote, and logs link now appear only when the run produced no report at all.
arthurpaulino
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR comment at #270 (comment) showed n/a for main-side prove-time, peak-rss, execute-time, and fft-cost: fetch-main keyed metrics by the measure's display NAME, and those four measures predate this pipeline with renamed display names ("Prove Time") — uploads attach to them by slug, so the name never matched our row keys.
fetch-main now reads the slug only, and every row key is born slug-shaped so that identity holds end to end: mergeSpans emits phase- (phase-stark-prove) instead of phase:, matching the slugs bencher already derived for the existing phase measures — history stays continuous and no console edits are needed. The registry metric lists were already slugs. Display names remain free to rename in the console; slugs must stay equal to the row vocabulary.
Verified against live bencher data at main's tip: all measures of an aiur-check-prove report come back under their row keys.