Skip to content

feat(playwright): warn when recommended Chromium launch options are missing#350

Merged
gregberge merged 1 commit into
mainfrom
greg/arg-405-show-a-warning-when-playwright-is-not-correctly-configured
Jul 23, 2026
Merged

feat(playwright): warn when recommended Chromium launch options are missing#350
gregberge merged 1 commit into
mainfrom
greg/arg-405-show-a-warning-when-playwright-is-not-correctly-configured

Conversation

@gregberge

Copy link
Copy Markdown
Member

What

Adds a startup check to the Argos Playwright reporter: on onBegin, it inspects the resolved Playwright config and warns when a Chromium project is missing the recommended launch args used to stabilize font rendering:

--disable-lcd-text
--font-render-hinting=none

The check:

  • Reads config.projects[].use.launchOptions.args from the fully-resolved FullConfig.
  • Only applies to Chromium projects (defaults to Chromium when browserName is unset), since these are Chromium-only flags.
  • Lists exactly which flags are missing, per project, with a link to the docs.

Also in this PR

  • Adds the recommended launchOptions.args to the package's own playwright.config.ts.
  • Updates all documentation links from /docs/sdks-reference/ to /docs/reference/ across packages and examples (the separate js-sdk-reference.argos-ci.com API-reference host is left untouched).

🤖 Generated with Claude Code

…issing

Add a check in the Argos Playwright reporter that inspects the resolved
config on `onBegin` and warns when a Chromium project is missing the
recommended launch args (`--disable-lcd-text`, `--font-render-hinting=none`)
used to stabilize font rendering.

Also add these args to the package's own playwright.config.ts and update
all docs links from `/docs/sdks-reference/` to `/docs/reference/`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jul 23, 2026

Copy link
Copy Markdown

ARG-405

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
argos-js-sdk-reference Ready Ready Preview, Comment Jul 23, 2026 9:25pm

Request Review

@gregberge
gregberge requested a review from jsfez July 23, 2026 21:26
@gregberge
gregberge merged commit d827d51 into main Jul 23, 2026
68 checks passed
@gregberge
gregberge deleted the greg/arg-405-show-a-warning-when-playwright-is-not-correctly-configured branch July 23, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant